[POOL-199] GOP/GKOP evict() method is not synchronised and is not thread-safe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 13/Dec/11 21:33
• Updated: 31/Dec/14 16:28
• Resolved: 14/Dec/11 22:16

Description

The evict() method in Pool2 GOP/GKOP classes is not synchronised, yet it relies on accessing and updating the field evictionIterator without any synchronisation.

Adding volatile to the field would help with safe publication across threads, but won't address the problem of two evictions running in parallel.

AFAICT, two threads running evict() in parallel could operate on the same objects, which will almost certainly cause problems.

The evict() method should probably be synchronised, which would also solve the safe publication problem.