[POOL-193] It is safer to make org.apache.commons.pool2.impl.GenericObjectPool.evictor volatile

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Nightly Builds
• Fix Version/s: 2.0
• Labels: concurrency

Environment

Platform: All

• Assignee: Unassigned
• Reporter: Samira Tasharofi
• Created: 29/Nov/11 19:32
• Updated: 31/Dec/14 16:29
• Resolved: 13/Dec/11 15:31

Description

A field of org.apache.commons.pool2.impl.GenericObjectPool<T> might need to be synchronized. Field org.apache.commons.pool2.impl.GenericObjectPool.evictor is read and written in method org.apache.commons.pool2.impl.GenericObjectPool.startEvictor(long), which might be called by multiple threads concurrently. Is there a possibility that org.apache.commons.pool2.impl.GenericObjectPool.startEvictor(long) gets invoked concurrently? Would it be safer to make org.apache.commons.pool2.impl.GenericObjectPool.evictor volatile?