[POOL-168] Thread Interrupt during borrowObject may lock pool

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.5.4
• Fix Version/s: 1.5.5

Environment

The pool is being used for a connection pool of SSH connections on slax.

• Assignee: Unassigned
• Reporter: YL
• Created: 27/Apr/10 08:14
• Updated: 25/May/10 12:45
• Resolved: 28/Apr/10 01:47

Description

We're using the pool quite intensively, with many borrow and return calls. The pool is set to WHEN_EXHAUSTED_BLOCK with a positive wait value (a few seconds). Sometimes, the thread that is waiting on the "latch.wait(waitTime)" call (Line 1112 in GenericObjectPool of version 1.5.4) may be interrupted. When that happens, the InterruptedException will be caught and rethrown correctly. However, after this happens, the pool becomes useless and no borrowObject calls succeed.

By looking at the code, it appears that some cleanup that is done in normal operation (right before the NoSuchElementException timeout exception is thrown) is not done in the case detailed above. It is possible that the cleanup should be done in the case of interruption as well, to ensure the pool continues to operate correctly.