[PLUTO-66] TestPortlet assumes testId will be a number

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: unspecified
• Fix Version/s: 1.0.1-rc2
• Component/s: portlets-testsuite
• Assignee: Unassigned
• Reporter: Ken Weiner
• Created: 23/Sep/04 00:58
• Updated: 22/Feb/07 04:58
• Resolved: 15/Oct/04 02:03

Description

In TestPortlet.doDispatch(), the following code assumes that the test portlet will be a number (line 127):

TestConfig config = null;
if(testId != null)

{ config = (TestConfig)configs.get(Integer.parseInt(testId)); }

This throws a java.lang.NumberFormatException when the testId has no value which is currently the case when you click the "Return to Index" button in the test portlet.

One way to fix this is to check for the case when testId is an empty String or when testId is not a number inside the getTestId(PortletRequest req) method. In that case, the method should return null.

For example, the first "if" block in that method could be changed to this (line 181):

if((testId == null || testId.trim().length() == 0) &&
next == null && previous == null && tests.size() > 0)

{ return null; }