[PLUTO-600] HttpServletPortletRequestWrapper.getAttribute delegates to wrapped ServletRequest

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.1.0
• Component/s: portlet container
• Assignee: Eric Dalquist
• Reporter: Eric Dalquist
• Created: 20/Oct/10 22:01
• Updated: 23/Nov/10 02:06
• Resolved: 21/Oct/10 02:37

Description

The HttpServletPortletRequestWrapper.getAttribute(String) method is doing fall back to retrieve the attribute from the underlying ServletRequest

// First try to retrieve the attribute from the (possibly buffered/cached/previously set) portletRequest
Object value = portletRequest.getAttribute(name);
// if null, fall back to retrieve the attribute from the web container itself
return value != null ? value : getRequest().getAttribute(name);

The problem with this is it nullifies the portal's ability to influence the request attributes that can be seen by a portlet and any servlets it dispatches to via the PortletRequestContext. Since the default PortletRequestContextImpl in Pluto already has the ServletRequest.getAttribute(String) fallback code I believe it can be removed from HttpServletPortletRequestWrapper.