[PLUTO-583] PortalURLParserImpl: unnecessary "?"

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.2, 2.1.0
• Component/s: portal driver
• Assignee: Ate Douma
• Reporter: Jürgen Gahl
• Created: 29/Oct/09 13:49
• Updated: 28/May/10 00:37
• Resolved: 28/May/10 00:37

Description

When creating an URL with "public String toString(PortalURL portalURL)" an unnecessary "?" is added if the query is empty (org.apache.pluto.driver.url.impl.PortalURLParserImpl).
This is the part of the source code where the URL is finally composed:

—
// Construct the string representing the portal URL.
// Fix for PLUTO-247 - check if query string contains parameters
if ( query.length() > 1 )

{ return buffer.append(query).toString(); }

// Construct the string representing the portal URL.
return buffer.append(query).toString();
—

There was already a fix for this issue (PLUTO-247). May be this reappeared after some refactoring. The statement in the if-block and the one behind the if-block is the same.
The unnecessary "?" caused problems when using the URL as action in a form within a HTTPUnit-Test because the testframework does not look at the final character of the URL and adds an additional "?".