Pluto
  1. Pluto
  2. PLUTO-486

The USER_INFO map is re-created every time the USER_INFO attribute is retrieved using getAttribute() on org.apache.pluto.internal.impl.PortletRequestImpl

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.5
    • Fix Version/s: 1.2.0, 2.0-refactoring, 1.1.6
    • Component/s: portlet container
    • Labels:
      None
    • Environment:
      Tomcat 5.5.26

      Description

      The method getAttribute() on org.apache.pluto.internal.impl.PortletRequestImpl currently handles the USER_INFO attribute as follows:

      if (PortletRequest.USER_INFO.equals(name))

      { return createUserInfoMap(); }

      It would be nice if the USER_INFO data were saved into a request attribute, instead of re-creating the map every time. For example:

      if (PortletRequest.USER_INFO.equals(name)) {
      Map userInfoMap = (Map) getHttpServletRequest().getAttribute(name);
      if (userInfoMap == null)

      { userInfoMap = createUserInfoMap(); getHttpServletRequest().setAttribute(name, userInfoMap); }

      return userInfoMap;
      }

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12565034 ] jira [ 12585917 ]
        Mark Thomas made changes -
        Workflow jira [ 12431078 ] Default workflow, editable Closed status [ 12565034 ]
        Eric Dalquist made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.2.0 [ 12312213 ]
        Fix Version/s 2.0-refactoring [ 12313313 ]
        Resolution Fixed [ 1 ]
        Hide
        Eric Dalquist added a comment -

        Generation of the USER_INFO Map was moved out into the DefaultRequestAttributeService so the fix was added there.

        Applied to trunk, 1.1-patches and 2.0-refactoring

        Show
        Eric Dalquist added a comment - Generation of the USER_INFO Map was moved out into the DefaultRequestAttributeService so the fix was added there. Applied to trunk, 1.1-patches and 2.0-refactoring
        Eric Dalquist committed 679513 (1 file)
        Eric Dalquist made changes -
        Assignee Eric Dalquist [ edalquist ]
        Nikita Dubrovsky made changes -
        Fix Version/s 1.1.6 [ 12313075 ]
        Nikita Dubrovsky made changes -
        Field Original Value New Value
        Attachment P486-1.1.x-Rev656347.diff [ 12382116 ]
        Hide
        Nikita Dubrovsky added a comment -

        Attached a patch with the proposed fix.

        Show
        Nikita Dubrovsky added a comment - Attached a patch with the proposed fix.
        Hide
        Craig Doremus added a comment -

        Thank you, Nikita, for pointing this out. Can you create a SVN patch to flesh out your solution?

        Show
        Craig Doremus added a comment - Thank you, Nikita, for pointing this out. Can you create a SVN patch to flesh out your solution?
        Nikita Dubrovsky created issue -

          People

          • Assignee:
            Eric Dalquist
            Reporter:
            Nikita Dubrovsky
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development