[PLUTO-486] The USER_INFO map is re-created every time the USER_INFO attribute is retrieved using getAttribute() on org.apache.pluto.internal.impl.PortletRequestImpl

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.5
• Fix Version/s: 1.2.0, 2.0-refactoring, 1.1.6
• Component/s: portlet container
• Environment: Tomcat 5.5.26
• Assignee: Eric Dalquist
• Reporter: Nikita Dubrovsky
• Created: 14/May/08 18:32
• Updated: 24/Jul/08 19:48
• Resolved: 24/Jul/08 19:48

Description

The method getAttribute() on org.apache.pluto.internal.impl.PortletRequestImpl currently handles the USER_INFO attribute as follows:

if (PortletRequest.USER_INFO.equals(name))

{ return createUserInfoMap(); }

It would be nice if the USER_INFO data were saved into a request attribute, instead of re-creating the map every time. For example:

if (PortletRequest.USER_INFO.equals(name)) {
Map userInfoMap = (Map) getHttpServletRequest().getAttribute(name);
if (userInfoMap == null)

{ userInfoMap = createUserInfoMap(); getHttpServletRequest().setAttribute(name, userInfoMap); }

return userInfoMap;
}