Pluto
  1. Pluto
  2. PLUTO-437

Icon support for portal pages listed in the navigation area

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.2.0, 1.1.6, 2.0.0
    • Fix Version/s: 1.1.8
    • Component/s: portal driver
    • Labels:
      None

      Description

      This is a request for an improvement to the portal driver that would allow for the optional display of an icon for each portal page listed in the navigation area.

      1. PLUTO-437-images.zip
        2 kB
        Paul McMahan
      2. PLUTO-437.png
        45 kB
        Paul McMahan
      3. PLUTO-437.diff
        6 kB
        Paul McMahan
      4. P437-1.1.x-Rev652071.diff
        6 kB
        Donald Woods

        Issue Links

          Activity

          Hide
          Paul McMahan added a comment -

          This patch can be applied at https://svn.apache.org/repos/asf/portals/pluto/trunk

          It includes the XML, CSS, JSP, and java source changes to implement the requested functionality. The images for this feature are copied from the Apache Geronimo project. I will attach them in a separate zip.

          Show
          Paul McMahan added a comment - This patch can be applied at https://svn.apache.org/repos/asf/portals/pluto/trunk It includes the XML, CSS, JSP, and java source changes to implement the requested functionality. The images for this feature are copied from the Apache Geronimo project. I will attach them in a separate zip.
          Hide
          Donald Woods added a comment -

          Updated patch created against 1.1.x branch at Rev652071

          Show
          Donald Woods added a comment - Updated patch created against 1.1.x branch at Rev652071
          Hide
          Donald Woods added a comment -

          Recreated patch for 1.1.x (using Rev652071) which didn't include the fix for PLUTO-484.

          Show
          Donald Woods added a comment - Recreated patch for 1.1.x (using Rev652071) which didn't include the fix for PLUTO-484 .
          Hide
          Donald Woods added a comment -

          Can we have this improvement considered for Pluto 1.1.6?
          We are using this feature in Apache Geronimo 2.1.2 and 2.2, which allows us to add user friendly icons to the navigation leafs in our Admin Console.
          Currently, we are using a private build of the 1.1.6-SNAPSHOT code to enable this in our distro.

          Show
          Donald Woods added a comment - Can we have this improvement considered for Pluto 1.1.6? We are using this feature in Apache Geronimo 2.1.2 and 2.2, which allows us to add user friendly icons to the navigation leafs in our Admin Console. Currently, we are using a private build of the 1.1.6-SNAPSHOT code to enable this in our distro.
          Hide
          David Jencks added a comment -

          This looks pretty unobjectionable to me, does anyone object if I apply the patch?

          to make review possibly easier, the main change here is:

          Index: pluto-portal-driver/src/main/java/org/apache/pluto/driver/services/portal/PageConfig.java
          ===================================================================
          — pluto-portal-driver/src/main/java/org/apache/pluto/driver/services/portal/PageConfig.java (revision 652071)
          +++ pluto-portal-driver/src/main/java/org/apache/pluto/driver/services/portal/PageConfig.java (working copy)
          @@ -25,6 +25,7 @@

          private String name;
          private String uri;
          + private String icon;
          private Collection portletIds;
          private int orderNumber;

          @@ -78,4 +79,12 @@
          return getName().hashCode() + "|"+portletIds.size();
          }

          + public String getIcon()

          { + return icon; + }

          +
          + public void setIcon(String icon)

          { + this.icon = icon; + }

          +
          }
          Index: pluto-portal-driver/src/main/resources/pluto-portal-driver-config.xsd
          ===================================================================
          — pluto-portal-driver/src/main/resources/pluto-portal-driver-config.xsd (revision 652071)
          +++ pluto-portal-driver/src/main/resources/pluto-portal-driver-config.xsd (working copy)
          @@ -59,6 +59,8 @@
          type="xs:string" />
          <xs:attribute name="uri"
          type="xs:string" />
          + <xs:attribute name="icon"
          + type="xs:string" />
          </xs:complexType>
          </xs:element>
          </xs:sequence>

          plus some (possibly optional) modifications to use the new feature in pluto-portal/src/main/resources/pluto-portal-driver-config.xml, pluto-portal/src/main/webapp/WEB-INF/themes/navigation.jsp, and pluto-portal/src/main/webapp/pluto.css

          Show
          David Jencks added a comment - This looks pretty unobjectionable to me, does anyone object if I apply the patch? to make review possibly easier, the main change here is: Index: pluto-portal-driver/src/main/java/org/apache/pluto/driver/services/portal/PageConfig.java =================================================================== — pluto-portal-driver/src/main/java/org/apache/pluto/driver/services/portal/PageConfig.java (revision 652071) +++ pluto-portal-driver/src/main/java/org/apache/pluto/driver/services/portal/PageConfig.java (working copy) @@ -25,6 +25,7 @@ private String name; private String uri; + private String icon; private Collection portletIds; private int orderNumber; @@ -78,4 +79,12 @@ return getName().hashCode() + "|"+portletIds.size(); } + public String getIcon() { + return icon; + } + + public void setIcon(String icon) { + this.icon = icon; + } + } Index: pluto-portal-driver/src/main/resources/pluto-portal-driver-config.xsd =================================================================== — pluto-portal-driver/src/main/resources/pluto-portal-driver-config.xsd (revision 652071) +++ pluto-portal-driver/src/main/resources/pluto-portal-driver-config.xsd (working copy) @@ -59,6 +59,8 @@ type="xs:string" /> <xs:attribute name="uri" type="xs:string" /> + <xs:attribute name="icon" + type="xs:string" /> </xs:complexType> </xs:element> </xs:sequence> plus some (possibly optional) modifications to use the new feature in pluto-portal/src/main/resources/pluto-portal-driver-config.xml, pluto-portal/src/main/webapp/WEB-INF/themes/navigation.jsp, and pluto-portal/src/main/webapp/pluto.css
          Hide
          Craig Doremus added a comment -

          I do not have an objection to this patch. However, it should be noted that Pluto is primarily a portlet container with a bare-bones portal. We have no plans to compete with Jetspeed and other portals. With that in mind, we have been very careful at adding new features to the portal.

          Please make sure the patch is applied to both the trunk and the 1.1.x branch.

          Show
          Craig Doremus added a comment - I do not have an objection to this patch. However, it should be noted that Pluto is primarily a portlet container with a bare-bones portal. We have no plans to compete with Jetspeed and other portals. With that in mind, we have been very careful at adding new features to the portal. Please make sure the patch is applied to both the trunk and the 1.1.x branch.
          Hide
          Ate Douma added a comment -

          I don't really have an object to this improvement either, but I agree with Graig we should be careful with adding enhancements to the Portal Driver beyond its purpose of being a testbed only for the container.
          As it seems this is only needed/asked for the 1.1.x version of Pluto, I'm removing the 2.0.0 fix target.

          Show
          Ate Douma added a comment - I don't really have an object to this improvement either, but I agree with Graig we should be careful with adding enhancements to the Portal Driver beyond its purpose of being a testbed only for the container. As it seems this is only needed/asked for the 1.1.x version of Pluto, I'm removing the 2.0.0 fix target.

            People

            • Assignee:
              Unassigned
              Reporter:
              Paul McMahan
            • Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development