Uploaded image for project: 'Pluto'
  1. Pluto
  2. PLUTO-247

PortalURLParser: Avoid putting '?' and '&' characters in query string if unnecessary

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.1.0-beta1
    • Fix Version/s: 1.1.0
    • Component/s: portal driver
    • Labels:
      None

      Description

      When building the query string in PortalURLParser, the URL ends up containing a '?' character, whether there's a query string or not (e.g. http://host/path/?) While not incorrect, it doesn't look very nice.

      A similar problem exists for query parameters. The query string always starts with an '&' character. (e.g. http://host/path/?&param=value)

        Activity

        Hide
        cziegeler Carsten Ziegeler added a comment -

        The problem should be fixed now.

        Can you please cross-check and then close this bug?

        Show
        cziegeler Carsten Ziegeler added a comment - The problem should be fixed now. Can you please cross-check and then close this bug?
        Hide
        dhay David Hay added a comment -

        I apparently didn't have enough nits to pick

        I happened to find this because we have some javascript code that assumed that the base URL was free of query parameters and always appended a "?" character to the URL. When we moved that code into a portlet, of course it stopped working becuase the "?" was already there.

        I realize that the problem was really with our code (which has been fixed) so this is really just a cosmetic fix, rather than a functional one.

        Show
        dhay David Hay added a comment - I apparently didn't have enough nits to pick I happened to find this because we have some javascript code that assumed that the base URL was free of query parameters and always appended a "?" character to the URL. When we moved that code into a portlet, of course it stopped working becuase the "?" was already there. I realize that the problem was really with our code (which has been fixed) so this is really just a cosmetic fix, rather than a functional one.
        Hide
        ddewolf David DeWolf added a comment -

        picky, picky, picky. . .ok, just kidding. . .fair enough

        Show
        ddewolf David DeWolf added a comment - picky, picky, picky. . .ok, just kidding. . .fair enough

          People

          • Assignee:
            cziegeler Carsten Ziegeler
            Reporter:
            dhay David Hay
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development