Uploaded image for project: 'Pluto'
  1. Pluto
  2. PLUTO-139

When calling FactoryManagerService.getFactory(), some arguments passed are not logic.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Won't Fix
    • 1.0.1
    • unspecified
    • portlet container
    • None

    Description

      The pluto container defines a set of Factory interfaces to create certain classes, such as classes in the "javax.portlet" package. In the FactoryManagerService interface, the following method is defined:

      public Factory getFactory(Class theClass);

      The method signature seems to mean that: get a factory instance that i can use to create the specified class (theClass). For example, pluto will call FactoryManagerService.getFactory(RenderRequest.class) to get a render request factory instance which may be used to create RenderRequest instances. Thus...

      1- In the "org.apache.pluto.util.ObjectIDAccess" class, to get an ObjectIDFactory instance, which may be used to create ObjectID instances, Pluto should call 'FactoryManagerService.getFactory(ObjectID.class)' instead of 'FactoryManagerService.getFactory(ObjectIDFactory.class)'.

      2 - In the "org.apache.pluto.om.ControllerObjectAccess" class, to get a ControllerFactory instance, which may be used to create Controller instances, Pluto should call 'FactoryManagerService.getFactory(Controller.class)' instead of 'FactoryManagerService.getFactory(ControllerFactory.class)'.

      Regards.
      ZHENG Zhong

      Attachments

        1. ObjectIDAccess.diff.txt
          0.3 kB
          @deprecated ZHENG Zhong
        2. FactoryManagerService.diff.txt
          0.5 kB
          @deprecated ZHENG Zhong
        3. ControllerObjectAccess.diff.txt
          0.3 kB
          @deprecated ZHENG Zhong

        Activity

          People

            Unassigned Unassigned
            heavyz @deprecated ZHENG Zhong
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: