Pivot
  1. Pivot
  2. PIVOT-837

TabPane with vertical tabOrientation and corner's content with top verticalAlignment

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.2
    • Component/s: wtk
    • Labels:
      None
    • Environment:
      GNU/Linux, SUN JDK 1.7 & 1.6

      Description

      Hi all,

      I'm facing another bug introduced in Pivot 2.0.1 which wasn't in 2.0. It's design issue of corner in TabPane with tabOrientation:'vertical'. It's impossible to have content of the corner vertically aligned at the top in TabPane which has tab orientation vertical. In version 2.0 it was possible to align it at the top, center and bottom but in version 2.0.1 it is always at the bottom. It seems that BoxPane in corner has only minimal space.
      TabPane with horizontal tab orientation has still the same correct behaviour in 2.0 and 2.0.1 so it's problem only with vertically oriented TabPane.

      I attach example application.

      Lukas

      1. TabPaneExample.java
        0.9 kB
        Lukas Machacek
      2. tabPaneExample_window.bxml
        0.6 kB
        Lukas Machacek
      3. tabPane_corner_inMyApplication_with2.0.png
        10 kB
        Lukas Machacek
      4. tabPane_corner_inMyApplication_with2.0.1.png
        5 kB
        Lukas Machacek
      5. tabPane_corner_2.0.png
        6 kB
        Lukas Machacek
      6. tabPane_corner_2.0.1.png
        5 kB
        Lukas Machacek
      7. PIVOT-837_fix.patch
        1 kB
        Lukas Machacek
      8. PIVOT-837_better_fix.patch
        2 kB
        Lukas Machacek

        Activity

        Hide
        Sandro Martini added a comment -

        Just committed the test case (renamed as others issue tests), thanks for now.

        Sorry, to have all data here, can you attach here a screenshot on the behaviour with Pivot 2.0 ?

        Thank you again,
        Sandro

        Show
        Sandro Martini added a comment - Just committed the test case (renamed as others issue tests), thanks for now. Sorry, to have all data here, can you attach here a screenshot on the behaviour with Pivot 2.0 ? Thank you again, Sandro
        Hide
        Lukas Machacek added a comment - - edited

        Attached screenshots from issue test case for 2.0 and 2.0.1 and also screenshots of one part of my application where I'm using it, so you can imagine for what I'm using it

        Lukas

        Show
        Lukas Machacek added a comment - - edited Attached screenshots from issue test case for 2.0 and 2.0.1 and also screenshots of one part of my application where I'm using it, so you can imagine for what I'm using it Lukas
        Hide
        Sandro Martini added a comment -

        Hi Lukas, thank you, now it's all much clear to me . I'll look at it.

        Show
        Sandro Martini added a comment - Hi Lukas, thank you, now it's all much clear to me . I'll look at it.
        Hide
        Lukas Machacek added a comment -

        Hi Sandro,

        I tested it more and found that the same problem is already for horizontal tabOrientation and corner's left horizontalAlignment.

        I prepared patch to fix this issue. With this fix TabPane have functionality of Pivot 2.0 (correct corner alignment) + correction of hiding of corner introduced in Pivot 2.0.1 (this correction caused the problem).

        Lukas

        Show
        Lukas Machacek added a comment - Hi Sandro, I tested it more and found that the same problem is already for horizontal tabOrientation and corner's left horizontalAlignment. I prepared patch to fix this issue. With this fix TabPane have functionality of Pivot 2.0 (correct corner alignment) + correction of hiding of corner introduced in Pivot 2.0.1 (this correction caused the problem). Lukas
        Hide
        Sandro Martini added a comment -

        Patch applied in revision 1241959.

        Lukas, thank you very much for the patch,
        Sandro

        Show
        Sandro Martini added a comment - Patch applied in revision 1241959. Lukas, thank you very much for the patch, Sandro
        Hide
        Sandro Martini added a comment -

        Resolved, but be free to reopen the issue if necessary.

        Show
        Sandro Martini added a comment - Resolved, but be free to reopen the issue if necessary.
        Hide
        Lukas Machacek added a comment -

        Hi Sandro,

        I'm very sorry, but I have to reopen this issue I found a regression in my patch which caused bad behaviour for opposite alignment.

        But I will attach another patch which finally solves all variations of alignment

        Lukas

        Show
        Lukas Machacek added a comment - Hi Sandro, I'm very sorry, but I have to reopen this issue I found a regression in my patch which caused bad behaviour for opposite alignment. But I will attach another patch which finally solves all variations of alignment Lukas
        Hide
        Lukas Machacek added a comment -

        Here is the promissed final patch ...

        Show
        Lukas Machacek added a comment - Here is the promissed final patch ...
        Hide
        Sandro Martini added a comment -

        Hi Lukas,
        thank you very much for the "better" fix , just applied it in revision 1291673.
        Note that I'm not been able to test it against all variations of alignment, but only in standard alignment as you can see in Pivot837.java ...

        Thanks again,
        Sandro

        Show
        Sandro Martini added a comment - Hi Lukas, thank you very much for the "better" fix , just applied it in revision 1291673. Note that I'm not been able to test it against all variations of alignment, but only in standard alignment as you can see in Pivot837.java ... Thanks again, Sandro
        Hide
        Sandro Martini added a comment -

        Now should be resolved, in all alignments.
        Thanks again to Lukas for the new patch.

        Show
        Sandro Martini added a comment - Now should be resolved, in all alignments. Thanks again to Lukas for the new patch.
        Hide
        Lukas Machacek added a comment -

        Hi Sandro,

        It was my fail that I didn't test all cases of alignment for the first time.
        Now everything is correct.

        Thanks again for commit.
        Lukas

        Show
        Lukas Machacek added a comment - Hi Sandro, It was my fail that I didn't test all cases of alignment for the first time. Now everything is correct. Thanks again for commit. Lukas
        Hide
        Sandro Martini added a comment -

        Hi Lukas, don't worry and thank you again.
        If you have other fixes/suggestions/etc, you are welcome .

        Bye

        Show
        Sandro Martini added a comment - Hi Lukas, don't worry and thank you again. If you have other fixes/suggestions/etc, you are welcome . Bye

          People

          • Assignee:
            Sandro Martini
            Reporter:
            Lukas Machacek
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development