Pivot
  1. Pivot
  2. PIVOT-817

Implement "borderThickness" style for TerraPushButtonSkin

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.5
    • Component/s: wtk-terra
    • Environment:
      Windows XP SP3, JDK 1.6.0_16

      Description

      In order to somewhat simulate the appearance of the "default" button on Windows, which has a thicker border, it would be nice to be able to set the border thickness of a PushButton to something bigger than one.

      1. thick.patch
        7 kB
        Roger Whitcomb

        Activity

        Hide
        Roger Whitcomb added a comment -

        The idea was to be able to make buttons look more like Windows buttons (the "default button" look), but the timeframe was unrealistic.

        Show
        Roger Whitcomb added a comment - The idea was to be able to make buttons look more like Windows buttons (the "default button" look), but the timeframe was unrealistic.
        Hide
        Roger Whitcomb added a comment -

        If it looked "right", that is, the same way Windows buttons do, then yes, I would use it. I don't "need" it by any particular date, since we just are releasing the product and it is unclear when the next release will be. I updated the due date just to get it off the top of the TO DO list. But, the due date could be erased, and it could be moved to 2.1 as well.

        Show
        Roger Whitcomb added a comment - If it looked "right", that is, the same way Windows buttons do, then yes, I would use it. I don't "need" it by any particular date, since we just are releasing the product and it is unclear when the next release will be. I updated the due date just to get it off the top of the TO DO list. But, the due date could be erased, and it could be moved to 2.1 as well.
        Hide
        Sandro Martini added a comment -

        Hi Roger, do you need this for 2.0.3 (as seen in the new Due Date) ?

        Show
        Sandro Martini added a comment - Hi Roger, do you need this for 2.0.3 (as seen in the new Due Date) ?
        Hide
        Roger Whitcomb added a comment -

        This needs a lot more thought. The simple "solution" looks terrible.

        Show
        Roger Whitcomb added a comment - This needs a lot more thought. The simple "solution" looks terrible.
        Hide
        Roger Whitcomb added a comment -

        There appears to be a visual problem with this fix when width is 2 (maybe something to do with antialiasing?), and width of 3 or greater just doesn't look good, at least not the way the Windows buttons look that I was trying to emulate. So, I'm going to rethink the solution.

        Postponing for a later release.

        Show
        Roger Whitcomb added a comment - There appears to be a visual problem with this fix when width is 2 (maybe something to do with antialiasing?), and width of 3 or greater just doesn't look good, at least not the way the Windows buttons look that I was trying to emulate. So, I'm going to rethink the solution. Postponing for a later release.
        Hide
        Roger Whitcomb added a comment -

        This patch implements the functionality, but there may be drawing problems when the thickness is 2. A value of 3 seems to be fine (as is the default of 1). Also, the focus rectangle doesn't do what I thought it would with the thick border either (it is in the same relative position as with a default border).

        So, someone should look over the changes to see if I've done something strange in the drawing code. Maybe all the + 2 and +1 and -1 values didn't all have to do with the border thickness...

        Show
        Roger Whitcomb added a comment - This patch implements the functionality, but there may be drawing problems when the thickness is 2. A value of 3 seems to be fine (as is the default of 1). Also, the focus rectangle doesn't do what I thought it would with the thick border either (it is in the same relative position as with a default border). So, someone should look over the changes to see if I've done something strange in the drawing code. Maybe all the + 2 and +1 and -1 values didn't all have to do with the border thickness...

          People

          • Assignee:
            Roger Whitcomb
            Reporter:
            Roger Whitcomb
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 168h
              168h
              Remaining:
              Remaining Estimate - 168h
              168h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development