Pivot
  1. Pivot
  2. PIVOT-807

Add new "showContentBevel" style to TerraFrameSkin to allow greater flexibility

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.0.1
    • Fix Version/s: 2.0.1
    • Component/s: wtk-terra
    • Labels:
    • Environment:
      Windows XP SP3, JDK 1.6.0_26

      Description

      The light-colored so-called "content bevel" is always shown underneath a Frame/Dialog title bar and inside the content border. For our purposes, it would be nice to have the additional flexibility to turn this inside bevel off in order to tweak the appearance of the frame or dialog.

      1. frame.patch
        5 kB
        Roger Whitcomb

        Activity

        Hide
        Roger Whitcomb added a comment -

        This "frame.patch" implements this feature. Not entirely sure I changed all the right constant values – there are a couple that look suspect to me, but I couldn't see any painting problems by either specifying 'true' or 'false' for the new "showContentBevel' style.

        Show
        Roger Whitcomb added a comment - This "frame.patch" implements this feature. Not entirely sure I changed all the right constant values – there are a couple that look suspect to me, but I couldn't see any painting problems by either specifying 'true' or 'false' for the new "showContentBevel' style.
        Hide
        Noel Grandin added a comment -

        Rather than creating a new field on the object, just compute the value in each method that needs it:
        int contentBevelHeight = showContentBevel ? 1 : 0;

        Show
        Noel Grandin added a comment - Rather than creating a new field on the object, just compute the value in each method that needs it: int contentBevelHeight = showContentBevel ? 1 : 0;
        Hide
        Roger Whitcomb added a comment -

        Hi Noel, I guess I was trying to make sure the calculation was consistent everywhere by (essentially) putting it in one place only. But, if you prefer not having another field, then I can do as you suggest.

        Show
        Roger Whitcomb added a comment - Hi Noel, I guess I was trying to make sure the calculation was consistent everywhere by (essentially) putting it in one place only. But, if you prefer not having another field, then I can do as you suggest.
        Hide
        Roger Whitcomb added a comment -

        Committed change with Noel's suggestions.

        SVN revision 1188501.

        Show
        Roger Whitcomb added a comment - Committed change with Noel's suggestions. SVN revision 1188501.

          People

          • Assignee:
            Roger Whitcomb
            Reporter:
            Roger Whitcomb
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development