Pivot
  1. Pivot
  2. PIVOT-719

Keyboard shortcut display is not correct on Windows XP platform

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.1
    • Component/s: wtk
    • Labels:
      None
    • Environment:
      Windows XP SP3, Java SE JDK/JRE 1.6

      Description

      All other Windows programs I have seen use "Alt+Shift+F" (using "+" as the final separator) for keyboard shortcuts. Pivot would render this "Alt+Shift-F" (using "-" as the final separator). In addition, if the key has no modifiers given (such as "F5") Pivot will render it as "-F5" (with leading separator).

      Bugs are in org.apache.pivot.wtk.Keyboard and org.apache.pivot.wtk.Platform

      1. ASF.LICENSE.NOT.GRANTED--windows-keyboard-shortcut-problem.jpg
        30 kB
        Roger Whitcomb
      2. ASF.LICENSE.NOT.GRANTED--windows-normal-usage-1.jpg
        30 kB
        Roger Whitcomb
      3. ASF.LICENSE.NOT.GRANTED--windows-normal-usage-2.jpg
        32 kB
        Roger Whitcomb
      4. keyboard.patch
        2 kB
        Roger Whitcomb
      5. menu_bar_test_to_see_the_fix_patch.patch
        1.0 kB
        Sandro Martini

        Activity

        Roger Whitcomb created issue -
        Hide
        Roger Whitcomb added a comment -

        Here is a screenshot showing the problems on Windows.

        Show
        Roger Whitcomb added a comment - Here is a screenshot showing the problems on Windows.
        Roger Whitcomb made changes -
        Field Original Value New Value
        Attachment windows-keyboard-shortcut-problem.jpg [ 12474037 ]
        Hide
        Roger Whitcomb added a comment -

        Example of normal Windows usage Ctrl+Alt+F

        Show
        Roger Whitcomb added a comment - Example of normal Windows usage Ctrl+Alt+F
        Roger Whitcomb made changes -
        Attachment windows-normal-usage-1.jpg [ 12474038 ]
        Hide
        Roger Whitcomb added a comment -

        Here is an example with just "F5".

        Show
        Roger Whitcomb added a comment - Here is an example with just "F5".
        Roger Whitcomb made changes -
        Attachment windows-normal-usage-2.jpg [ 12474039 ]
        Hide
        Roger Whitcomb added a comment -

        Here is a patch to fix both problems.

        Show
        Roger Whitcomb added a comment - Here is a patch to fix both problems.
        Roger Whitcomb made changes -
        Attachment keyboard.patch [ 12474040 ]
        Hide
        Sandro Martini added a comment -

        Hi Roger, thank you very much (even for the patch), tomorrow I'll try and say something ... if possible (as time) I'll try to write (or add to an existing one) a small test, to see the new (fixed) behavior.

        Bye,
        Sandro

        Show
        Sandro Martini added a comment - Hi Roger, thank you very much (even for the patch), tomorrow I'll try and say something ... if possible (as time) I'll try to write (or add to an existing one) a small test, to see the new (fixed) behavior. Bye, Sandro
        Sandro Martini made changes -
        Assignee Sandro Martini [ smartini ]
        Hide
        Sandro Martini added a comment -

        with this small change now you can see how the patch from Roger looks good (I tested it on Windows, but I'm sure it's ok even on other platforms). This little patch is to add a Refresh (linked to F5 key) menu item in the View menu element, running the MenuBarTest (under Tests).

        If there aren't objections I'll commit Roger and mine patch as soon as possible.

        Show
        Sandro Martini added a comment - with this small change now you can see how the patch from Roger looks good (I tested it on Windows, but I'm sure it's ok even on other platforms). This little patch is to add a Refresh (linked to F5 key) menu item in the View menu element, running the MenuBarTest (under Tests). If there aren't objections I'll commit Roger and mine patch as soon as possible.
        Sandro Martini made changes -
        Hide
        Sandro Martini added a comment -

        Patch committed, thank you very much Roger.
        Be free to reopen this ticket if something should re-happen here.

        Bye,
        Sandro

        Show
        Sandro Martini added a comment - Patch committed, thank you very much Roger. Be free to reopen this ticket if something should re-happen here. Bye, Sandro
        Sandro Martini made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        6d 1h 38m 1 Sandro Martini 24/Mar/11 23:55

          People

          • Assignee:
            Sandro Martini
            Reporter:
            Roger Whitcomb
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development