[PIVOT-577] Time.decode() throws NPE when no milliseconds present in input string

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5
• Fix Version/s: 2.0
• Component/s: core-util
• Environment: JDK 6 Update 21
• Assignee: Gregory K. Brown
• Reporter: Ilian Pavlov
• Created: 21/Jul/10 23:53
• Updated: 22/Jul/10 13:57
• Resolved: 22/Jul/10 13:43

Description

Time.decode("12:34:56.789");
works,

Time.decode("12:34:56")
throws a NullPointerException at org.apache.pivot.util.Time.decode(Time.java:399)

I believe the problem is that matcher.groupCount() returns # of groups in pattern, not # of matched, so it always ==5; thus when no milliseconds passed, matcher.group(4) is null.

if (matcher.groupCount() == 5)

{ millisecond = Integer.parseInt(matcher.group(4).substring(1)); }

else

{ millisecond = 0; }