Pivot
  1. Pivot
  2. PIVOT-460

Addtional maximized argument for desktop applications

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.5
    • Component/s: wtk
    • Labels:
      None

      Description

      An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.

        Activity

        Hide
        Alejandro Vilar added a comment -

        This patch includes the MAXIMIZED_ARGUMENT constant and is also saved in the user preferences like other arguments.

        Show
        Alejandro Vilar added a comment - This patch includes the MAXIMIZED_ARGUMENT constant and is also saved in the user preferences like other arguments.
        Hide
        Greg Brown added a comment -

        I have applied the patch. Note that, while .java files are OK, patches are more commonly submitted as .patch files generated by the diff command. This makes it a little easier to scan the patch up front before applying it.

        Thank you for your contribution!

        Show
        Greg Brown added a comment - I have applied the patch. Note that, while .java files are OK, patches are more commonly submitted as .patch files generated by the diff command. This makes it a little easier to scan the patch up front before applying it. Thank you for your contribution!
        Hide
        Alejandro Vilar added a comment -

        Sorry for this, but I have to update the previous patch, it doesn't keeps the last maximized state in the user preferences, I'm attaching another patch.

        Thanks

        Show
        Alejandro Vilar added a comment - Sorry for this, but I have to update the previous patch, it doesn't keeps the last maximized state in the user preferences, I'm attaching another patch. Thanks
        Hide
        Greg Brown added a comment -

        Could you possibly resubmit the patch using unified diff format? You can just type "svn diff > maximized_argument.patch" in your trunk root directory.

        Show
        Greg Brown added a comment - Could you possibly resubmit the patch using unified diff format? You can just type "svn diff > maximized_argument.patch" in your trunk root directory.
        Hide
        Greg Brown added a comment -

        Actually, could you try applying this patch and see if it resolves your problem? Run this command in your trunk root:

        patch -p0 < maximized_argument.patch

        If you are on Windows and don't have the patch command, you can use this:

        http://sourceforge.net/projects/unxutils/

        Unzip it to c:\ and make sure that c:\usr\local\wbin is on your path.

        Show
        Greg Brown added a comment - Actually, could you try applying this patch and see if it resolves your problem? Run this command in your trunk root: patch -p0 < maximized_argument.patch If you are on Windows and don't have the patch command, you can use this: http://sourceforge.net/projects/unxutils/ Unzip it to c:\ and make sure that c:\usr\local\wbin is on your path.
        Hide
        Alejandro Vilar added a comment -

        Here is the patch in unified format, currently I'm using netbeans to apply the patch and works fine.

        Show
        Alejandro Vilar added a comment - Here is the patch in unified format, currently I'm using netbeans to apply the patch and works fine.
        Hide
        Greg Brown added a comment -

        Were you able to apply the alternate patch I posted?

        Show
        Greg Brown added a comment - Were you able to apply the alternate patch I posted?
        Hide
        Greg Brown added a comment -

        I have committed this change. Please let me know if you see any issues with it.

        Show
        Greg Brown added a comment - I have committed this change. Please let me know if you see any issues with it.
        Hide
        Alejandro Vilar added a comment -

        Greg,
        I was able to apply your patch and install UnxUtils, I'm submitting another patch based on yours, because whenever the frame is closed the x,y,width and height attributes will be saved ignoring if the window status is maximized, iconified or normal. For example if the app is closed while is maximized the location will be pointing to 0,0, the dimensions to the maximum bounds and when the application is loaded again it will be start maximized but when the user press the restore button the window will be restored to the maximum bounds with no changes apparently.

        Regards
        -A

        Show
        Alejandro Vilar added a comment - Greg, I was able to apply your patch and install UnxUtils, I'm submitting another patch based on yours, because whenever the frame is closed the x,y,width and height attributes will be saved ignoring if the window status is maximized, iconified or normal. For example if the app is closed while is maximized the location will be pointing to 0,0, the dimensions to the maximum bounds and when the application is loaded again it will be start maximized but when the user press the restore button the window will be restored to the maximum bounds with no changes apparently. Regards -A
        Hide
        Greg Brown added a comment -

        Patch applied. Let me know if you run into any other issues, and thanks for the submission!

        Show
        Greg Brown added a comment - Patch applied. Let me know if you run into any other issues, and thanks for the submission!

          People

          • Assignee:
            Unassigned
            Reporter:
            Alejandro Vilar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development