Pivot
  1. Pivot
  2. PIVOT-316

FileBrowser sorting improvements

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Component/s: wtk
    • Labels:
      None

      Description

      FileBrowser could benefit from two sorting improvements:

      1) When it's created, it doesn't explicitly sort the table view on any column, thus leaving the file sort order up to the OS. This is non-deterministic and leads to the files being in seemingly random order on some platforms. We should explicitly set the default column sort order to be file name ascending.

      2) When you re-sort the table view, the text input containing the selected file gets cleared (if it contained text of a file not found in the current folder). The selected file should be preserved across sorts.

      3) TerraFileBrowserSkin's default sort (NAME) should put folders before files. This would cause the default sort to sort by folders alphabetically, then by files alphabetically. Currently, all folders and files are sorted alphabetically, with folders and files intermingled.

        Activity

        Todd Volkert created issue -
        Hide
        Todd Volkert added a comment -

        #1 is done.

        #2 is being caused in part by us not maintaining the selection state of the table view when we re-sort.

        Show
        Todd Volkert added a comment - #1 is done. #2 is being caused in part by us not maintaining the selection state of the table view when we re-sort.
        Greg Brown made changes -
        Field Original Value New Value
        Description FileBrowser could benefit from two sorting improvements:

        1) When it's created, it doesn't explicitly sort the table view on any column, thus leaving the file sort order up to the OS. This is non-deterministic and leads to the files being in seemingly random order on some platforms. We should explicitly set the default column sort order to be file name ascending.

        2) When you re-sort the table view, the text input containing the selected file gets cleared (if it contained text of a file not found in the current folder). The selected file should be preserved across sorts.
        FileBrowser could benefit from two sorting improvements:

        1) When it's created, it doesn't explicitly sort the table view on any column, thus leaving the file sort order up to the OS. This is non-deterministic and leads to the files being in seemingly random order on some platforms. We should explicitly set the default column sort order to be file name ascending.

        2) When you re-sort the table view, the text input containing the selected file gets cleared (if it contained text of a file not found in the current folder). The selected file should be preserved across sorts.

        3) TerraFileBrowserSkin's default sort (NAME) should put folders before files. This would cause the default sort to sort by folders alphabetically, then by files alphabetically. Currently, all folders and files are sorted alphabetically, with folders and files intermingled.
        Hide
        Todd Volkert added a comment -

        #3 is done. All the left is to maintain selection and text input contents when the comparator changes.

        Show
        Todd Volkert added a comment - #3 is done. All the left is to maintain selection and text input contents when the comparator changes.
        Greg Brown made changes -
        Assignee Greg Brown [ gbrown ]
        Greg Brown made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Todd Volkert made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        27d 11m 1 Greg Brown 03/Nov/09 15:09
        In Progress In Progress Resolved Resolved
        3d 2h 40m 1 Todd Volkert 06/Nov/09 17:50

          People

          • Assignee:
            Greg Brown
            Reporter:
            Todd Volkert
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development