Uploaded image for project: 'Pivot'
  1. Pivot
  2. PIVOT-1011

Move ListenerList implementations of interfaces into the interface itself

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Environment:
      All

      Description

      A universal paradigm in Pivot is to have a "listener" interface for a class or data structure that is used to notify listeners of changes in the class/data. There is then an "Adapter" static class in the interface file that implements the interface with default implementations. Then there is a very separate enclosed static class that implements the "ListenerList" interface of that listener interface. And usually (or always) this "listener list" class is defined/used only in the class that needs to notify the listeners. However, this class must be very parallel to not only the interface itself, but also the "Adapter" class, and yet it is in a different place.

      So, it seems somewhat reasonable to move all these "listener list" classes into the interfaces themselves, so all three related things are located in the same file. A preliminary POC of this concept was done with "Query.java", and "QueryListener.java" and it looks good.

      This doesn't seem to require changes to client code, because the accessor methods only refer to "ListenerList<....>" and not to the listener list class itself (in order to be more general, of course), but which helps us to hide the implementing class away inside the interface.

      I will attach the diff of the POC, to hopefully make this more clear. It may seem a somewhat nebulous concept, but the idea is to keep "like things" together for clarity.

        Attachments

        1. 1011.diffs
          4 kB
          Roger Lee Whitcomb

          Activity

            People

            • Assignee:
              rwhitcomb Roger Lee Whitcomb
              Reporter:
              rwhitcomb Roger Lee Whitcomb
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: