Pig
  1. Pig
  2. PIG-957

Tutorial is broken with 0.4 branch and trunk

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As I was testing the Pig Tutorial in preparation for the release, I found that we broke the second script both in local mode and in MR mode. The issue has to do with schema and naming fields.

      Here is what I see:

      java -cp pig.jar org.apache.pig.Main -x local script2-local.pig

      2009-09-11 12:52:46,961 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR 1000: Error during parsing. Invalid alias: hour00::group::ngram in

      {group::ngram: chararray,group::hour: chararray,hour00::count: long,ngram: chararray,hour: chararray,hour12::count: long}

      09/09/11 12:52:46 ERROR grunt.Grunt: ERROR 1000: Error during parsing. Invalid alias: hour00::group::ngram in

      {group::ngram: chararray,group::hour: chararray,hour00::count: long,ngram: chararray,hour: chararray,hour12::count: long}
      1. PIG-957.patch
        4 kB
        Pradeep Kamath
      2. PIG-957-2.patch
        5 kB
        Pradeep Kamath

        Activity

        Hide
        Pradeep Kamath added a comment -

        Patch committed to both trunk and branch-0.4

        Show
        Pradeep Kamath added a comment - Patch committed to both trunk and branch-0.4
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12419544/PIG-957-2.patch
        against trunk revision 814075.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/27/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/27/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/27/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419544/PIG-957-2.patch against trunk revision 814075. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/27/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/27/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/27/console This message is automatically generated.
        Hide
        Olga Natkovich added a comment -

        Pradeep, please, commit. The change is trivial enough not to wait for another automated test run.

        Show
        Olga Natkovich added a comment - Pradeep, please, commit. The change is trivial enough not to wait for another automated test run.
        Hide
        Daniel Dai added a comment -

        +1

        Show
        Daniel Dai added a comment - +1
        Hide
        Pradeep Kamath added a comment -

        There were two unit test failures in the last patch
        1) TestPigServer had a failure which was because join's describe now prefixes the outer relation alias for each field - corrected the test case to update the expected result.
        2) TestSkewedJoin had a timeout - this ran fine on my local box.

        Resubmitting with just the change in 1) above.

        Show
        Pradeep Kamath added a comment - There were two unit test failures in the last patch 1) TestPigServer had a failure which was because join's describe now prefixes the outer relation alias for each field - corrected the test case to update the expected result. 2) TestSkewedJoin had a timeout - this ran fine on my local box. Resubmitting with just the change in 1) above.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12419363/PIG-957.patch
        against trunk revision 814075.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/6/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/6/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/6/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419363/PIG-957.patch against trunk revision 814075. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/6/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/6/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/6/console This message is automatically generated.
        Hide
        Daniel Dai added a comment -

        +1

        Show
        Daniel Dai added a comment - +1
        Hide
        Pradeep Kamath added a comment -

        Attached patch to address the issue. LOJoin's getSchema() now keeps both the disambiguated (outeralias::inneralis) alias and the simple inner alias for non duplicate columns coming out of the LOJoin.

        Show
        Pradeep Kamath added a comment - Attached patch to address the issue. LOJoin's getSchema() now keeps both the disambiguated (outeralias::inneralis) alias and the simple inner alias for non duplicate columns coming out of the LOJoin.

          People

          • Assignee:
            Pradeep Kamath
            Reporter:
            Olga Natkovich
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development