Pig
  1. Pig
  2. PIG-939

Checkstyle pulls in junit3.7 which causes the build of test code to fail.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.4.0
    • Component/s: build
    • Labels:
      None

      Description

      Pig fails to compile if you execute:

      ant -D<associated flags for various components> clean findbugs checkstyle test

      It gets the error:

      [javac] Compiling 153 source files to /export/crawlspace/kryptonite/hadoopqa/workspace/workspace/CCDI-Pig-2.3/pig-2.3.0.0.20.0.2967040009/build/test/classes
      [javac] /export/crawlspace/kryptonite/hadoopqa/workspace/workspace/CCDI-Pig-2.3/pig-2.3.0.0.20.0.2967040009/test/org/apache/pig/test/PigExecTestCase.java:31: cannot find symbol
      [javac] symbol : constructor TestCase()
      [javac] location: class junit.framework.TestCase
      [javac] public abstract class PigExecTestCase extends TestCase {
      [javac] ^

      Once that's done, there's a copy of junit 3.7 cached from ivy that will continue to cause the build to fail. It will succeed, if you remove it, and then do:

      ant -D<associated flags for various components> clean findbugs test

      This proves it's running checkstyle that pulls in junit 3.7

      1. pig-939.patch
        1 kB
        Giridharan Kesavan

        Activity

        Hide
        Giridharan Kesavan added a comment -

        this patch should fix this issue of downloading junit-3.7

        Show
        Giridharan Kesavan added a comment - this patch should fix this issue of downloading junit-3.7
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12418232/pig-939.patch
        against trunk revision 806668.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/6/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/6/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/6/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418232/pig-939.patch against trunk revision 806668. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/6/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/6/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/6/console This message is automatically generated.
        Hide
        Giridharan Kesavan added a comment -

        Can someone review this?
        -Giri

        Show
        Giridharan Kesavan added a comment - Can someone review this? -Giri
        Hide
        Lee Tucker added a comment -

        +1 change has fixed it so junit 3.7 no longer downloads

        Show
        Lee Tucker added a comment - +1 change has fixed it so junit 3.7 no longer downloads
        Hide
        Alan Gates added a comment -

        Why is antlr being added as a dependency? I don't think Pig uses antlr.

        Show
        Alan Gates added a comment - Why is antlr being added as a dependency? I don't think Pig uses antlr.
        Hide
        Giridharan Kesavan added a comment -

        Its not pig which depends on antlr but checkstyle depends on antlr and thats the reason antlr is defined under conf="checkstyle->master"
        http://mvnrepository.com/artifact/checkstyle/checkstyle/4.2 - has the details of checkstyle's transient dependency.

        Show
        Giridharan Kesavan added a comment - Its not pig which depends on antlr but checkstyle depends on antlr and thats the reason antlr is defined under conf="checkstyle->master" http://mvnrepository.com/artifact/checkstyle/checkstyle/4.2 - has the details of checkstyle's transient dependency.
        Hide
        Alan Gates added a comment -

        +1

        Show
        Alan Gates added a comment - +1
        Hide
        Hadoop QA added a comment -

        To test jira cli

        Show
        Hadoop QA added a comment - To test jira cli
        Hide
        Hadoop QA added a comment -

        To test jira cli

        Show
        Hadoop QA added a comment - To test jira cli

          People

          • Assignee:
            Giridharan Kesavan
            Reporter:
            Lee Tucker
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development