Pig
  1. Pig
  2. PIG-700

To automate the pig patch test process

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.3.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Giridharan Kesavan created issue -
      Hide
      Giridharan Kesavan added a comment -

      Proposal to add a new ant patch test target

      Objective
      To automatically run check on the patch when a patch is made available.

      check's include
      1) Check if the patch contains author tag
      2) Check if the patch has also contributed any new testcase
      3) Check if the patch merges seemlessly without any conflict with the current trunk code.
      4) Check if patch has introduced any new java warnings.
      5) Exceute the test target to see if everything passes.
      Finally update the jira with the jira with the patch check comments.

      Enhancements:
      We can also add - findbugs, rats for release audit at later point to enhance this patch test automation process.

      Show
      Giridharan Kesavan added a comment - Proposal to add a new ant patch test target Objective To automatically run check on the patch when a patch is made available. check's include 1) Check if the patch contains author tag 2) Check if the patch has also contributed any new testcase 3) Check if the patch merges seemlessly without any conflict with the current trunk code. 4) Check if patch has introduced any new java warnings. 5) Exceute the test target to see if everything passes. Finally update the jira with the jira with the patch check comments. Enhancements: We can also add - findbugs, rats for release audit at later point to enhance this patch test automation process.
      Giridharan Kesavan made changes -
      Field Original Value New Value
      Assignee Giridharan Kesavan [ gkesavan ]
      Hide
      Nigel Daley added a comment -

      Giri, why not get the findbugs and rat targets into Pig first and then run the exact same test-patch.sh script that Hadoop does?

      Show
      Nigel Daley added a comment - Giri, why not get the findbugs and rat targets into Pig first and then run the exact same test-patch.sh script that Hadoop does?
      Hide
      Giridharan Kesavan added a comment -

      Yeah we can do that, I thought we would just start with the test-patch ant target and later enhance it with other targets.
      I would file jira's to include findbugs and rats target for pig and work on them
      Tnx!

      Show
      Giridharan Kesavan added a comment - Yeah we can do that, I thought we would just start with the test-patch ant target and later enhance it with other targets. I would file jira's to include findbugs and rats target for pig and work on them Tnx!
      Hide
      Giridharan Kesavan added a comment - - edited

      test-patch.sh script resides in at http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch dir.

      To get this pulled as part of pig trunk we may have to configure svn:externals..

      Commands to configure svn externals for test-patch.sh script..

      check out pig trunk
      cd <pig-trunk>
      export EDITOR=vim
      svn propedit svn:externals test
      [ the above step will open up the vim editor type in the following line and save it]
      bin http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch
      svn commit

      Show
      Giridharan Kesavan added a comment - - edited test-patch.sh script resides in at http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch dir. To get this pulled as part of pig trunk we may have to configure svn:externals.. Commands to configure svn externals for test-patch.sh script.. check out pig trunk cd <pig-trunk> export EDITOR=vim svn propedit svn:externals test [ the above step will open up the vim editor type in the following line and save it] bin http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch svn commit
      Hide
      Nigel Daley added a comment -

      +1 looks good.

      Show
      Nigel Daley added a comment - +1 looks good.
      Hide
      Santhosh Srinivasan added a comment -

      Steps documented in the JIRA were followed and the resulting changes committed. Thanks Giri for putting PIG into the world of automated patch testing.

      Show
      Santhosh Srinivasan added a comment - Steps documented in the JIRA were followed and the resulting changes committed. Thanks Giri for putting PIG into the world of automated patch testing.
      Santhosh Srinivasan made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Hadoop Flags [Reviewed]
      Resolution Fixed [ 1 ]
      Alan Gates made changes -
      Fix Version/s 0.3.0 [ 12313785 ]
      Alan Gates made changes -
      Status Resolved [ 5 ] Closed [ 6 ]

        People

        • Assignee:
          Giridharan Kesavan
          Reporter:
          Giridharan Kesavan
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development