[PIG-598] Parameter substitution ($PARAMETER) should not be performed in comments

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.2.0
• Fix Version/s: 0.7.0
• Component/s: impl
• Assignee: Thejas Nair
• Reporter: David Ciemiewicz
• Created: 06/Jan/09 00:23
• Updated: 14/May/10 06:45
• Resolved: 24/Nov/09 17:11

Description

Compiling the following code example will generate an error that $NOT_A_PARAMETER is an Undefined Parameter.

This is problematic as sometimes you want to comment out parts of your code, including parameters so that you don't have to define them.

This I think it would be really good if parameter substitution was not performed in comments.

-- $NOT_A_PARAMETER

-bash-3.00$ pig -exectype local -latest comment.pig
USING: /grid/0/gs/pig/current
java.lang.RuntimeException: Undefined parameter : NOT_A_PARAMETER
        at org.apache.pig.tools.parameters.PreprocessorContext.substitute(PreprocessorContext.java:221)
        at org.apache.pig.tools.parameters.ParameterSubstitutionPreprocessor.parsePigFile(ParameterSubstitutionPreprocessor.java:106)
        at org.apache.pig.tools.parameters.ParameterSubstitutionPreprocessor.genSubstitutedFile(ParameterSubstitutionPreprocessor.java:86)
        at org.apache.pig.Main.runParamPreprocessor(Main.java:394)
        at org.apache.pig.Main.main(Main.java:296)

Issue Links

• is duplicated by: PIG-267 Don't substitute parameters inside comments
• is related to: PIG-267 Don't substitute parameters inside comments