Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-5293

Suspicious code as missing `this' for a member

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.18.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Hi
      In a recent github mirror, I've found suspicious code.
      Branch: trunk
      Path: src/org/apache/pig/pen/util/ExampleTuple.java

      ...
       39     Tuple t = null;
      ...
      110     @Override
      111     public void reference(Tuple t) {
      112         t.reference(t);
      113     }
      

      In Line 112, `t.reference' should be `this.t.reference'? This might be just a trivial thing as the class name as ExampleTuple. But I wanted to report just in case.

      Thanks!

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                lifove JC
                Reporter:
                lifove JC
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: