Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-5248

Fix TestCombiner#testGroupByLimit after PigOnSpark merge

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.17.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This test started failing on TEZ after we merged PoS. The test checks if there is a "Combiner plan" among the vertices of Tez execution plan.
      The last step of the query is pigServer.registerQuery("d = limit c 2 ; "); which is decisive in the case of Tez. It looks like if we check the plan for "d" there is no combiner part, but there is one if we check it for "c" - so without applying limit.

      The reason this didn't come out before is because the alias supplied to checkCombinerUsed method was disregarded and alias "c" was checked always. This was recently fixed with the PoS merge. (See diff of TestCombiner here )

        Attachments

        1. PIG-5248-1.patch
          2 kB
          Rohini Palaniswamy

          Issue Links

            Activity

              People

              • Assignee:
                rohini Rohini Palaniswamy
                Reporter:
                szita Ádám Szita
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: