[PIG-4795] Flushing ObjectOutputStream before calling toByteArray on the underlying ByteArrayOutputStream

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.16.0
• Labels: easyfix patch
• Patch Info: Patch Available
• Hadoop Flags: Reviewed
• Flags: Patch
• Assignee: emopers
• Reporter: emopers
• Created: 04/Feb/16 05:29
• Updated: 08/Jun/16 20:48
• Resolved: 05/Feb/16 06:00

Description

In PigSplit.java

    private void writeObject(Serializable obj, DataOutput os)
            throws IOException {
        ByteArrayOutputStream baos = new ByteArrayOutputStream();
        ObjectOutputStream oos = new ObjectOutputStream(baos);
        oos.writeObject(obj);
        byte[] bytes = baos.toByteArray();
        os.writeInt(bytes.length);
        os.write(bytes);
    }

When an ObjectOutputStream instance wraps an underlying ByteArrayOutputStream instance,
it is recommended to flush or close the ObjectOutputStream before invoking the underlying instances's toByteArray(). Also, it is a good practice to call flush/close explicitly as mentioned for example at http://stackoverflow.com/questions/2984538/how-to-use-bytearrayoutputstream-and-dataoutputstream-simultaneously-java.
The patch adds a flush method before calling toByteArray().