Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-3984

PigServer.shutdown remove the tez resource folder

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0
    • Component/s: tez
    • Labels:
      None

      Description

      PIG-3978 make tez resource folder live across sessions. However, if PigServer.shutdown is called, tez resource folder will be removed and following job will fail. Bunch of tez unit test fail due to this.

      1. PIG-3984-1.patch
        3 kB
        Daniel Dai
      2. PIG-3984-2.patch
        6 kB
        Daniel Dai
      3. PIG-3984-3.patch
        8 kB
        Rohini Palaniswamy

        Activity

        Hide
        daijy Daniel Dai added a comment -

        bump

        Show
        daijy Daniel Dai added a comment - bump
        Hide
        rohini Rohini Palaniswamy added a comment -

        Shouldn't we clean the resource path up when exiting the grunt shell,end of execution of pig script and termination due to Ctrl+C(ShutdownHook) ?

        Show
        rohini Rohini Palaniswamy added a comment - Shouldn't we clean the resource path up when exiting the grunt shell,end of execution of pig script and termination due to Ctrl+C(ShutdownHook) ?
        Hide
        daijy Daniel Dai added a comment -

        Addressing Rohini's review comments.

        Show
        daijy Daniel Dai added a comment - Addressing Rohini's review comments.
        Hide
        rohini Rohini Palaniswamy added a comment -

        +1. I was trying to get all tez unit tests to passing before uploading patch for PIG-3935. So went ahead and committed to trunk. Thanks Daniel.

        I made two minor changes to the patch before committing. Moved FileLocalizer.deleteTempResourceFiles(); inside if(deleteTempFiles) and changed if (resourcePath != null) to if (resourcePath.get() != null) . Uploaded the final patch as PIG-3984-3.patch

        Show
        rohini Rohini Palaniswamy added a comment - +1. I was trying to get all tez unit tests to passing before uploading patch for PIG-3935 . So went ahead and committed to trunk. Thanks Daniel. I made two minor changes to the patch before committing. Moved FileLocalizer.deleteTempResourceFiles(); inside if(deleteTempFiles) and changed if (resourcePath != null) to if (resourcePath.get() != null) . Uploaded the final patch as PIG-3984 -3.patch

          People

          • Assignee:
            daijy Daniel Dai
            Reporter:
            daijy Daniel Dai
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development