[PIG-39] BufferedPositionedInputStream drastically reduces read performance because it doesn't override read([], o, l) in InputStream

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.1.0
• Component/s: impl

Environment

Java 1.6, Mac OS X 10.5

• Assignee: Unassigned
• Reporter: Sam Pullara
• Created: 30/Nov/07 00:03
• Updated: 03/Jul/08 18:12
• Resolved: 21/Dec/07 00:42

Description

Simple fix can have a huge effect on performance of certain kinds of PIG programs:

Index: src/org/apache/pig/impl/io/BufferedPositionedInputStream.java
===================================================================
— src/org/apache/pig/impl/io/BufferedPositionedInputStream.java (revision 597597)
+++ src/org/apache/pig/impl/io/BufferedPositionedInputStream.java (working copy)
@@ -49,7 +49,14 @@
pos += rc;
return rc;
}

• +
  + @Override
  + public int read(byte b[], int off, int len) throws IOException

  { + int read = in.read(b, off, len); + pos += read; + return read; + }

  +
  /**

• Returns the current position in the tracked InputStream.
  */