[PIG-3894] Datetime function AddDuration, SubtractDuration and all Between functions don't check for null values in the input tuple.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Labels: datetime easyfix
• Assignee: Jenny Thompson
• Reporter: Jenny Thompson
• Created: 14/Apr/14 21:22
• Updated: 07/Jul/14 18:08
• Resolved: 21/Apr/14 19:48

Description

The simple datetime functions: GetMonth, GetHour, ToDate, GetYear etc all have safe treatment of null values in the input tuple.

e.g.

GetMonth.java

@Override
public Integer exec(Tuple input) throws IOException {
    if (input == null || input.size() < 1 || input.get(0) == null) {
        return null;
    }
    return ((DateTime) input.get(0)).getMonthOfYear();
}

However, all of the "Duration" or "Between" functions are missing this null-checking, and so fail completely when the are passed tuples with null values.

e.g.

AddDuration.java

@Override
public DateTime exec(Tuple input) throws IOException {
    if (input == null || input.size() < 2) {
        return null;
    }
    return ((DateTime) input.get(0)).plus(new Period((String) input.get(1)));
}

This is inconsistent, problematic and easy to fix.