Pig
  1. Pig
  2. PIG-3776

Conflicting versions of jline is present in trunk

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: build
    • Labels:
      None

      Description

      This is a regression of PIG-3573.

      In ivy/libraries.properties, the version of jline is specified as 0.9.94-

      jline.version=0.9.94
      

      But since jline is also a dependency of accumulo, jline-1.0.jar is pulled down at compile time-

      $ ls build/ivy/lib/Pig/jline-*
      build/ivy/lib/Pig/jline-1.0.jar
      

      Now when pig-withouthadoop.jar is built, jline-1.0.jar is not packaged because ant looks for jline-0.9.94.jar-

      <include name="jline-${jline.version}.jar"/>
      

      This causes a ClassNotFount exception at runtime.

      1. PIG-3776-1.patch
        1 kB
        Cheolsoo Park

        Issue Links

          Activity

          Cheolsoo Park created issue -
          Cheolsoo Park made changes -
          Field Original Value New Value
          Link This issue is broken by PIG-3573 [ PIG-3573 ]
          Hide
          Cheolsoo Park added a comment -

          In the attached patch, I am doing two things-

          1. Bump jline.version to 1.0 in libraries.properties.
          2. Exclude jline from dependencies of accumulo so the version of jline is explicitly controlled by libraries.properties.
          Show
          Cheolsoo Park added a comment - In the attached patch, I am doing two things- Bump jline.version to 1.0 in libraries.properties. Exclude jline from dependencies of accumulo so the version of jline is explicitly controlled by libraries.properties.
          Cheolsoo Park made changes -
          Attachment PIG-3776-1.patch [ 12630587 ]
          Cheolsoo Park made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Josh Elser added a comment -

          Oops, sorry for not catching that Cheolsoo Park. Verified that jline is not included in the -withouthadoop.jar and that it is included after applying the patch.

          Show
          Josh Elser added a comment - Oops, sorry for not catching that Cheolsoo Park . Verified that jline is not included in the -withouthadoop.jar and that it is included after applying the patch.
          Hide
          Daniel Dai added a comment -

          +1

          Show
          Daniel Dai added a comment - +1
          Hide
          Cheolsoo Park added a comment -

          Committed to trunk. Thank you Josh and Daniel for reviewing the patch!

          Show
          Cheolsoo Park added a comment - Committed to trunk. Thank you Josh and Daniel for reviewing the patch!
          Cheolsoo Park made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Daniel Dai made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          4m 48s 1 Cheolsoo Park 23/Feb/14 23:19
          Patch Available Patch Available Resolved Resolved
          2h 51m 1 Cheolsoo Park 24/Feb/14 02:10
          Resolved Resolved Closed Closed
          133d 15h 56m 1 Daniel Dai 07/Jul/14 18:07

            People

            • Assignee:
              Cheolsoo Park
              Reporter:
              Cheolsoo Park
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development