Pig
  1. Pig
  2. PIG-3741

Utils.setTmpFileCompressionOnConf can cause side effect for SequenceFileInterStorage

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.1, 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently, Utils.setTmpFileCompressionOnConf(pigContext, conf); is invoked for every job. In case of Seqfile, this api sets mapreduce params on conf to assist SequenceFileInterStorage. However, as a side effect, this might change the behavior of other storers due to these mapred properties. This api should only be called for jobs with intermediate storage.

      1. PIG-3741.patch
        4 kB
        Aniket Mokashi

        Activity

        Hide
        Aniket Mokashi added a comment -

        Committed to 0.12.1 branch and trunk. Thanks Julien Le Dem for the review!

        Show
        Aniket Mokashi added a comment - Committed to 0.12.1 branch and trunk. Thanks Julien Le Dem for the review!
        Hide
        Julien Le Dem added a comment -

        Ideally each store would get its own config object, but that would be a major refactoring.
        In the meantime, this looks like a good improvement to me.
        +1

        Show
        Julien Le Dem added a comment - Ideally each store would get its own config object, but that would be a major refactoring. In the meantime, this looks like a good improvement to me. +1

          People

          • Assignee:
            Aniket Mokashi
            Reporter:
            Aniket Mokashi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development