Pig
  1. Pig
  2. PIG-3561

Clean up PigStats and JobStats after PIG-3419

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      This is a clean up that I did as part of PIG-3514 and PIG-3541. I'd like to commit this in trunk so tez branch won't diverge from trunk.

      1. PIG-3561-1.patch
        41 kB
        Cheolsoo Park
      2. PIG-3561-2.patch
        42 kB
        Cheolsoo Park

        Activity

        Hide
        Cheolsoo Park added a comment -

        Thank you Daniel for the review. Committed to trunk.

        Show
        Cheolsoo Park added a comment - Thank you Daniel for the review. Committed to trunk.
        Hide
        Daniel Dai added a comment -

        +1 for trunk.

        Show
        Daniel Dai added a comment - +1 for trunk.
        Hide
        Cheolsoo Park added a comment -

        All unit tests pass.

        Show
        Cheolsoo Park added a comment - All unit tests pass.
        Show
        Cheolsoo Park added a comment - https://reviews.apache.org/r/15390/
        Hide
        Cheolsoo Park added a comment -

        The attached patch factors out a few methods/fields that can be used by MR and non-MR backends into PigStats and JobStats. PIG-3419 used to move them to SimplePigStats and MRJobStats, but I found these are not MR-specific and applicable to non-MR backends such as Tez backend.

        ant test-commit passes.

        Show
        Cheolsoo Park added a comment - The attached patch factors out a few methods/fields that can be used by MR and non-MR backends into PigStats and JobStats. PIG-3419 used to move them to SimplePigStats and MRJobStats, but I found these are not MR-specific and applicable to non-MR backends such as Tez backend. ant test-commit passes.

          People

          • Assignee:
            Cheolsoo Park
            Reporter:
            Cheolsoo Park
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development