Pig
  1. Pig
  2. PIG-3525

PigStats.get() and ScriptState.get() shouldn't return MR-specific objects

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.13.0
    • Component/s: impl
    • Labels:
      None

      Description

      After PIG-3419, PigStats and ScriptState are no longer MR-specific classes. But PigStats.get() and ScriptState.get() methods still return MR-specific objects (SimplePigStats and MRScriptState respectively). We should deprecate these method and provide a new way to create appropriate objects based on the ExecType.

      1. PIG-3525-1.patch
        15 kB
        Cheolsoo Park
      2. PIG-3525-2.patch
        15 kB
        Cheolsoo Park
      3. PIG-3525-3.patch
        16 kB
        Cheolsoo Park

        Issue Links

          Activity

          Cheolsoo Park created issue -
          Cheolsoo Park made changes -
          Field Original Value New Value
          Link This issue is required by PIG-3446 [ PIG-3446 ]
          Hide
          Cheolsoo Park added a comment -

          Attached is a patch that make these get() functions return proper type of objects based on the exec type.

          Show
          Cheolsoo Park added a comment - Attached is a patch that make these get() functions return proper type of objects based on the exec type.
          Cheolsoo Park made changes -
          Attachment PIG-3525-1.patch [ 12614256 ]
          Cheolsoo Park made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Cheolsoo Park made changes -
          Attachment PIG-3525-2.patch [ 12614258 ]
          Hide
          Cheolsoo Park added a comment -

          Canceling the patch since it doesn't fix the issue.

          Show
          Cheolsoo Park added a comment - Canceling the patch since it doesn't fix the issue.
          Cheolsoo Park made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Cheolsoo Park added a comment -

          Updating a proper fix. The RB link is here-
          https://reviews.apache.org/r/15634/

          Show
          Cheolsoo Park added a comment - Updating a proper fix. The RB link is here- https://reviews.apache.org/r/15634/
          Cheolsoo Park made changes -
          Attachment PIG-3525-3.patch [ 12614320 ]
          Cheolsoo Park made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Rohini Palaniswamy added a comment -

          +1. Looks good to me

          Show
          Rohini Palaniswamy added a comment - +1. Looks good to me
          Hide
          Cheolsoo Park added a comment -

          Committed to trunk. Thank you Rohini for the review!

          Show
          Cheolsoo Park added a comment - Committed to trunk. Thank you Rohini for the review!
          Cheolsoo Park made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Daniel Dai made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          2h 37m 1 Cheolsoo Park 17/Nov/13 01:50
          Open Open Patch Available Patch Available
          31d 15h 55m 2 Cheolsoo Park 18/Nov/13 01:25
          Patch Available Patch Available Resolved Resolved
          13h 59m 1 Cheolsoo Park 18/Nov/13 15:25
          Resolved Resolved Closed Closed
          231d 2h 42m 1 Daniel Dai 07/Jul/14 19:08

            People

            • Assignee:
              Cheolsoo Park
              Reporter:
              Cheolsoo Park
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development