Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: tez-branch
    • Fix Version/s: tez-branch
    • Component/s: tez
    • Labels:
      None

      Description

      After DAG is submitted to the cluster, we should return job status to the client. TezStats is a subclass of PigStats that encapsulates this information.

      1. PIG-3514-1.patch
        38 kB
        Cheolsoo Park
      2. PIG-3514-2.patch
        44 kB
        Cheolsoo Park

        Activity

        Cheolsoo Park created issue -
        Hide
        Cheolsoo Park added a comment -
        Show
        Cheolsoo Park added a comment - ReviewBoard link: https://reviews.apache.org/r/14776/
        Cheolsoo Park made changes -
        Field Original Value New Value
        Attachment PIG-3514-1.patch [ 12609303 ]
        Cheolsoo Park made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Cheolsoo Park made changes -
        Attachment PIG-3514-2.patch [ 12609345 ]
        Hide
        Prashant Kommireddi added a comment -

        Hi Cheolsoo Park - any reason for leaving out TezTaskStats from TezTasks.display(), other than the fact that TezTaskStats is not entirely implemented yet?

        Show
        Prashant Kommireddi added a comment - Hi Cheolsoo Park - any reason for leaving out TezTaskStats from TezTasks.display(), other than the fact that TezTaskStats is not entirely implemented yet?
        Hide
        Cheolsoo Park added a comment -

        Prashant Kommireddi, thank you for taking a look. Per-task stats is not implemented yet. I wanted to at least provide a basic implementation to unblock other jiras. Patches for improvement is welcome!

        Committed to tez-branch. Thank you Daniel for the review!

        Show
        Cheolsoo Park added a comment - Prashant Kommireddi , thank you for taking a look. Per-task stats is not implemented yet. I wanted to at least provide a basic implementation to unblock other jiras. Patches for improvement is welcome! Committed to tez-branch. Thank you Daniel for the review!
        Cheolsoo Park made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Prashant Kommireddi added a comment -

        Cheolsoo Park - sounds good. I noticed the code being duplicated between SimplePigStats and TezStats, I am sure it could be refactored for better re-use at a later point. Just curious as I learn more about Tez, at some point contributions will happen

        Show
        Prashant Kommireddi added a comment - Cheolsoo Park - sounds good. I noticed the code being duplicated between SimplePigStats and TezStats, I am sure it could be refactored for better re-use at a later point. Just curious as I learn more about Tez, at some point contributions will happen
        Hide
        Cheolsoo Park added a comment -

        Yes, there is duplicate logic for different types. It should be certainly refactored. Please do not hesitate to chime in!

        Show
        Cheolsoo Park added a comment - Yes, there is duplicate logic for different types. It should be certainly refactored. Please do not hesitate to chime in!
        Daniel Dai made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        8d 7h 5m 1 Cheolsoo Park 20/Oct/13 09:48
        Patch Available Patch Available Resolved Resolved
        1d 15h 54m 1 Cheolsoo Park 22/Oct/13 01:42
        Resolved Resolved Closed Closed
        395d 5h 16m 1 Daniel Dai 21/Nov/14 05:58

          People

          • Assignee:
            Cheolsoo Park
            Reporter:
            Cheolsoo Park
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development