Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: tez-branch
    • Fix Version/s: tez-branch
    • Component/s: tez
    • Labels:
      None

      Description

      After DAG is submitted to the cluster, we should return job status to the client. TezStats is a subclass of PigStats that encapsulates this information.

      1. PIG-3514-1.patch
        38 kB
        Cheolsoo Park
      2. PIG-3514-2.patch
        44 kB
        Cheolsoo Park

        Activity

        Hide
        Cheolsoo Park added a comment -
        Show
        Cheolsoo Park added a comment - ReviewBoard link: https://reviews.apache.org/r/14776/
        Hide
        Prashant Kommireddi added a comment -

        Hi Cheolsoo Park - any reason for leaving out TezTaskStats from TezTasks.display(), other than the fact that TezTaskStats is not entirely implemented yet?

        Show
        Prashant Kommireddi added a comment - Hi Cheolsoo Park - any reason for leaving out TezTaskStats from TezTasks.display(), other than the fact that TezTaskStats is not entirely implemented yet?
        Hide
        Cheolsoo Park added a comment -

        Prashant Kommireddi, thank you for taking a look. Per-task stats is not implemented yet. I wanted to at least provide a basic implementation to unblock other jiras. Patches for improvement is welcome!

        Committed to tez-branch. Thank you Daniel for the review!

        Show
        Cheolsoo Park added a comment - Prashant Kommireddi , thank you for taking a look. Per-task stats is not implemented yet. I wanted to at least provide a basic implementation to unblock other jiras. Patches for improvement is welcome! Committed to tez-branch. Thank you Daniel for the review!
        Hide
        Prashant Kommireddi added a comment -

        Cheolsoo Park - sounds good. I noticed the code being duplicated between SimplePigStats and TezStats, I am sure it could be refactored for better re-use at a later point. Just curious as I learn more about Tez, at some point contributions will happen

        Show
        Prashant Kommireddi added a comment - Cheolsoo Park - sounds good. I noticed the code being duplicated between SimplePigStats and TezStats, I am sure it could be refactored for better re-use at a later point. Just curious as I learn more about Tez, at some point contributions will happen
        Hide
        Cheolsoo Park added a comment -

        Yes, there is duplicate logic for different types. It should be certainly refactored. Please do not hesitate to chime in!

        Show
        Cheolsoo Park added a comment - Yes, there is duplicate logic for different types. It should be certainly refactored. Please do not hesitate to chime in!

          People

          • Assignee:
            Cheolsoo Park
            Reporter:
            Cheolsoo Park
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development