Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-3456

Reduce threadlocal conf access in backend for each record

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.11.1
    • 0.14.0
    • None
    • None
    • Reviewed

    Description

      Noticed few things while browsing code

      1) DefaultTuple has a protected boolean isNull = false; which is never used. Removing this gives ~3-5% improvement for big jobs
      2) Config checking with ThreadLocal conf is repeatedly done for each record. For eg: createDataBag in POCombinerPackage. But initialized only for first time in other places like POPackage, POJoinPackage, etc.

      Attachments

        1. PIG-3456-fixtest.patch
          0.4 kB
          Daniel Dai
        2. PIG-3456-3.patch
          31 kB
          Rohini Palaniswamy
        3. PIG-3456-2.patch
          31 kB
          Rohini Palaniswamy
        4. PIG-3456-1-no-whitespace.patch
          26 kB
          Cheolsoo Park
        5. PIG-3456-1.patch
          40 kB
          Rohini Palaniswamy

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. PIG-3730 Performance issue in SelfSpillBag

          • Major - Major loss of function.
          • Closed

          Activity

            People

              rohini Rohini Palaniswamy
              rohini Rohini Palaniswamy
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: