Pig
  1. Pig
  2. PIG-3456

Reduce threadlocal conf access in backend for each record

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.1
    • Fix Version/s: 0.14.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Noticed few things while browsing code

      1) DefaultTuple has a protected boolean isNull = false; which is never used. Removing this gives ~3-5% improvement for big jobs
      2) Config checking with ThreadLocal conf is repeatedly done for each record. For eg: createDataBag in POCombinerPackage. But initialized only for first time in other places like POPackage, POJoinPackage, etc.

      1. PIG-3456-1.patch
        40 kB
        Rohini Palaniswamy
      2. PIG-3456-1-no-whitespace.patch
        26 kB
        Cheolsoo Park
      3. PIG-3456-2.patch
        31 kB
        Rohini Palaniswamy
      4. PIG-3456-3.patch
        31 kB
        Rohini Palaniswamy
      5. PIG-3456-fixtest.patch
        0.4 kB
        Daniel Dai

        Issue Links

          Activity

          Daniel Dai made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Daniel Dai made changes -
          Attachment PIG-3456-fixtest.patch [ 12676986 ]
          Rohini Palaniswamy made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Rohini Palaniswamy made changes -
          Attachment PIG-3456-3.patch [ 12676722 ]
          Rohini Palaniswamy made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Rohini Palaniswamy made changes -
          Attachment PIG-3456-2.patch [ 12676109 ]
          Aniket Mokashi made changes -
          Fix Version/s 0.14.0 [ 12326954 ]
          Fix Version/s 0.13.0 [ 12324971 ]
          Rohini Palaniswamy made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Cheolsoo Park made changes -
          Attachment PIG-3456-1-no-whitespace.patch [ 12627770 ]
          Rohini Palaniswamy made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Affects Version/s 0.11.1 [ 12324080 ]
          Fix Version/s 0.13.0 [ 12324971 ]
          Rohini Palaniswamy made changes -
          Attachment PIG-3456-1.patch [ 12626169 ]
          Rohini Palaniswamy made changes -
          Link This issue is related to PIG-3730 [ PIG-3730 ]
          Rohini Palaniswamy made changes -
          Field Original Value New Value
          Summary Some minor performance improvements Reduce threadlocal conf access in backend for each record
          Rohini Palaniswamy created issue -

            People

            • Assignee:
              Rohini Palaniswamy
              Reporter:
              Rohini Palaniswamy
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development