Pig
  1. Pig
  2. PIG-3414

QueryParserDriver.parseSchema(String) silently returns a wrong result when a comma is missing in the schema definition

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: parser
    • Labels:
      None

      Description

      QueryParserDriver provides a convenient method to parse from string to LogicalSchema. But if a comma is missing between two fields in the schema definition, it silently returns a wrong result. For example,

      a:int b:long
      

      This string will be parsed up to "a:int", and "b:long" will be silently discarded. This should rather fail with a parser exception.

      1. PIG-3414-6.patch
        16 kB
        Cheolsoo Park
      2. PIG-3414-5.patch
        4 kB
        Cheolsoo Park
      3. PIG-3414-4.patch
        4 kB
        Cheolsoo Park
      4. PIG-3414-3.patch
        3 kB
        Cheolsoo Park
      5. PIG-3414-2.patch
        4 kB
        Cheolsoo Park
      6. PIG-3414.patch
        3 kB
        Cheolsoo Park

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Cheolsoo Park
            Reporter:
            Cheolsoo Park
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development