Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.2.0
    • Component/s: None
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      This is from email on pig-dev from Bertrand Delacretaz:

      I wrote a blog post [3] while mentoring Wicket, it might help as an overview.

      > ...I found some online documents
      > (http://incubator.apache.org/guides/releasemanagement.htm) about it
      > but I don't have a very good feel for what is the minimal set of
      > things we need to do to get ready....

      I'd say the minimal set is

      1) Check that the required external libraries (if any) can be distributed, see [2]

      2) Create the required NOTICE and LICENSE files, see [1] and [2]

      3) Generate distribution artifacts which include this info

      4) Call for review of these artifacts, followed by a vote here and then a vote by the Incubator PMC.

      -Bertrand

      [1] http://incubator.apache.org/guides/releasemanagement.html
      [2] http://people.apache.org/~cliffs/3party.html
      [3] http://www.codeconsult.ch/bertrand/archives/000759.html

      1. PIG-34_v_1.patch
        13 kB
        Stefan Groschupf
      2. PIG-34-v02.patch
        72 kB
        Benjamin Francisoud
      3. PIG-34_tar.patch
        3 kB
        Olga Natkovich
      4. rat.report
        113 kB
        Olga Natkovich

        Activity

        Hide
        Stefan Groschupf added a comment -

        This patch adds
        LICENSE.txt, NOTICE.txt and README.txt.
        Also there is a new ant target (ant release) that also generates a md5 checksum file as requested for the PMC release process.
        I'm not a license expert but looks like the jars we use are all BSD license what would be ok based on this reading:
        http://people.apache.org/~rubys/3party.html#criteriaandcategories
        However someone needs to double check that.

        Show
        Stefan Groschupf added a comment - This patch adds LICENSE.txt, NOTICE.txt and README.txt. Also there is a new ant target (ant release) that also generates a md5 checksum file as requested for the PMC release process. I'm not a license expert but looks like the jars we use are all BSD license what would be ok based on this reading: http://people.apache.org/~rubys/3party.html#criteriaandcategories However someone needs to double check that.
        Hide
        Benjamin Francisoud added a comment -

        Same patch as v1 but add all missing apache license headers to .java files and build.xml

        Show
        Benjamin Francisoud added a comment - Same patch as v1 but add all missing apache license headers to .java files and build.xml
        Hide
        Stefan Groschupf added a comment -

        Benjamin, awesome. Thanks!
        +1

        Show
        Stefan Groschupf added a comment - Benjamin, awesome. Thanks! +1
        Hide
        Olga Natkovich added a comment -

        Benjaming, this is great, thanks!

        I want to wait a little bit before committing this patch. I want to let PIG-111 to go ahead of this change to make sure that it is easier to integrate into the code. Once PIG-111 is committed, I will work on this patch.

        Show
        Olga Natkovich added a comment - Benjaming, this is great, thanks! I want to wait a little bit before committing this patch. I want to let PIG-111 to go ahead of this change to make sure that it is easier to integrate into the code. Once PIG-111 is committed, I will work on this patch.
        Hide
        Pi Song added a comment -

        Just out of my curiosity. I found Jsch lib in Pig source base. It is based on BSD-style license (see http://www.jcraft.com/jsch/LICENSE.txt). Will that be compatible with Apache license?

        Show
        Pi Song added a comment - Just out of my curiosity. I found Jsch lib in Pig source base. It is based on BSD-style license (see http://www.jcraft.com/jsch/LICENSE.txt ). Will that be compatible with Apache license?
        Hide
        Benjamin Francisoud added a comment -

        Olga> yes I do also prefer PIG-111 to be commited that this one
        Pi Song> According to the license:

        Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

        I suppose if we include a jsch-license.txt in pig release jar, we would be meeting jsch license terms, wdyt ?

        Show
        Benjamin Francisoud added a comment - Olga> yes I do also prefer PIG-111 to be commited that this one Pi Song> According to the license: Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. I suppose if we include a jsch-license.txt in pig release jar, we would be meeting jsch license terms, wdyt ?
        Hide
        Pi Song added a comment -

        Sorry I've just spotted Stefan's first comment. That should be fine then.

        BTW, anyone please confirm this.

        Show
        Pi Song added a comment - Sorry I've just spotted Stefan's first comment. That should be fine then. BTW, anyone please confirm this.
        Hide
        Olga Natkovich added a comment -

        I know this issue has been neglected for a while. I would like for us to focus again on an external release.

        Can the patch be regenerated? Also, can the script that finds/adds missing license be attached to this issue. Thanks.

        Show
        Olga Natkovich added a comment - I know this issue has been neglected for a while. I would like for us to focus again on an external release. Can the patch be regenerated? Also, can the script that finds/adds missing license be attached to this issue. Thanks.
        Hide
        Olga Natkovich added a comment -

        Licenses:

        Software Distribution License Authorized Comments
        -------------------------------------------------------------------------------------------------------------------------------------
        1 javacc binary BSD yes
        2 junit not distributed CPL reciprocal should be ok since we don't ditribute it
        3 hadoop binary + source Apache yes
        4 bzip2 source Apache yes we modify the source code
        5 jsch binary Modified BSD ?
        6 shock source ?? ?

        I have a couple of questions regarding the license:

        (1) Ben - what is the situation with shock code as far as the license?
        (2) To our mentors - what is the policy regarding modified BSF license as the case with jsch?
        (3) To our mentors - I assume that it is ok to modify code with apache license, is this correct?

        Show
        Olga Natkovich added a comment - Licenses: Software Distribution License Authorized Comments ------------------------------------------------------------------------------------------------------------------------------------- 1 javacc binary BSD yes 2 junit not distributed CPL reciprocal should be ok since we don't ditribute it 3 hadoop binary + source Apache yes 4 bzip2 source Apache yes we modify the source code 5 jsch binary Modified BSD ? 6 shock source ?? ? I have a couple of questions regarding the license: (1) Ben - what is the situation with shock code as far as the license? (2) To our mentors - what is the policy regarding modified BSF license as the case with jsch? (3) To our mentors - I assume that it is ok to modify code with apache license, is this correct?
        Hide
        Olga Natkovich added a comment -

        this patch is out of date; needs to be updated

        Show
        Olga Natkovich added a comment - this patch is out of date; needs to be updated
        Hide
        Benjamin Reed added a comment -

        I wrote shock and it was contributed as part of Pig to Apache, so it shouldn't be considered a separate piece of code in that respect.

        Show
        Benjamin Reed added a comment - I wrote shock and it was contributed as part of Pig to Apache, so it shouldn't be considered a separate piece of code in that respect.
        Hide
        Johannes Zillmann added a comment -

        regarding the junit comment...
        I think there is still junit inside the one pig.jar the build.xml builds.
        (actually it the build.xml build 2 jars one with dependencies and one without)
        So i think right now you would distribute it.

        Show
        Johannes Zillmann added a comment - regarding the junit comment... I think there is still junit inside the one pig.jar the build.xml builds. (actually it the build.xml build 2 jars one with dependencies and one without) So i think right now you would distribute it.
        Hide
        Olga Natkovich added a comment -

        Johannes you are correct.

        It would be pretty easy to change build.xml to only pull junit in when we build test target but not for regular jar.

        Show
        Olga Natkovich added a comment - Johannes you are correct. It would be pretty easy to change build.xml to only pull junit in when we build test target but not for regular jar.
        Hide
        Olga Natkovich added a comment -

        I added missing licenses to java and build.xml files. I made sure that

        • rat no longer complains about missing license
        • all builds are successful: trunk, contrib, tutorial
        • all unit tests are passing

        please, let me know if you see any issues

        Show
        Olga Natkovich added a comment - I added missing licenses to java and build.xml files. I made sure that rat no longer complains about missing license all builds are successful: trunk, contrib, tutorial all unit tests are passing please, let me know if you see any issues
        Hide
        Olga Natkovich added a comment -

        Added NOTICE, README, and LICENSE files

        Also bulk updated all fixed/closed JIRAs with fix version of 0.1.0.

        Next is to add build target that constructs the release tar file

        Show
        Olga Natkovich added a comment - Added NOTICE, README, and LICENSE files Also bulk updated all fixed/closed JIRAs with fix version of 0.1.0. Next is to add build target that constructs the release tar file
        Hide
        Olga Natkovich added a comment -

        This patch is to create a release tar file. Please, take a look.

        Show
        Olga Natkovich added a comment - This patch is to create a release tar file. Please, take a look.
        Hide
        Bertrand Delacretaz added a comment -

        > (2) To our mentors - what is the policy regarding modified BSF license as the case with jsch?

        It depends on what's modified, could you attach the license text here (or a link) so that we can have a look?

        Feel free to contact legal-discuss@apache.org about this if needed, or see http://www.apache.org/legal/3party.html and http://www.apache.org/legal/resolved.html

        > (3) To our mentors - I assume that it is ok to modify code with apache license, is this correct?

        Yes, and I think it's fair to credit the original authors in a README file, or maybe NOTICE, depending on the original source.

        Show
        Bertrand Delacretaz added a comment - > (2) To our mentors - what is the policy regarding modified BSF license as the case with jsch? It depends on what's modified, could you attach the license text here (or a link) so that we can have a look? Feel free to contact legal-discuss@apache.org about this if needed, or see http://www.apache.org/legal/3party.html and http://www.apache.org/legal/resolved.html > (3) To our mentors - I assume that it is ok to modify code with apache license, is this correct? Yes, and I think it's fair to credit the original authors in a README file, or maybe NOTICE, depending on the original source.
        Hide
        Olga Natkovich added a comment -

        Thanks Bertrand. Here is the text of the license: http://www.jcraft.com/jsch/LICENSE.txt

        Show
        Olga Natkovich added a comment - Thanks Bertrand. Here is the text of the license: http://www.jcraft.com/jsch/LICENSE.txt
        Hide
        Olga Natkovich added a comment -

        tar patch committed

        Show
        Olga Natkovich added a comment - tar patch committed
        Hide
        Olga Natkovich added a comment -
        Show
        Olga Natkovich added a comment - This report is to match http://people.apache.org/~olga/pig-0.1.0-candidate-3/
        Hide
        Olga Natkovich added a comment -

        we have done several releases already

        Show
        Olga Natkovich added a comment - we have done several releases already

          People

          • Assignee:
            Olga Natkovich
            Reporter:
            Olga Natkovich
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development