Pig
  1. Pig
  2. PIG-3189

Remove ivy/pig.pom and improve build mvn targets

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None

      Description

      ivy/pig.pom in SVN seems to no longer be used. At build time (ant set-version via ant mvn-deploy) ivy/pig.pom is generated from ivy/pig-template.xml. We should remove ivy/pig.pom from SVN.

      It would also be good to decouple building the maven artifacts from publishing them, since those two tasks might be done on different hosts.

      1. PIG-3189.1.patch
        2 kB
        Bill Graham
      2. PIG-3189.2.patch
        7 kB
        Bill Graham
      3. PIG-3189.3.patch
        49 kB
        Bill Graham
      4. PIG-3189.4.patch
        7 kB
        Bill Graham

        Activity

        Bill Graham created issue -
        Hide
        Bill Graham added a comment -

        Attaching a patch. Patch doesn't include deletion of ivy/pig.pom since I can't seem to get that reflected once the file is deleted.

        Show
        Bill Graham added a comment - Attaching a patch. Patch doesn't include deletion of ivy/pig.pom since I can't seem to get that reflected once the file is deleted.
        Bill Graham made changes -
        Field Original Value New Value
        Attachment PIG-3189.1.patch [ 12569637 ]
        Bill Graham made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Jonathan Coveney added a comment -

        Bill, are you using git? git rm file should reflect the deletion. Does it not?

        Show
        Jonathan Coveney added a comment - Bill, are you using git? git rm file should reflect the deletion. Does it not?
        Hide
        Jonathan Coveney added a comment -

        Also, +1

        Show
        Jonathan Coveney added a comment - Also, +1
        Hide
        Bill Graham added a comment -

        git rm did not, but just rm did the trick. Here's patch 2 which reflects the delete.

        Show
        Bill Graham added a comment - git rm did not, but just rm did the trick. Here's patch 2 which reflects the delete.
        Bill Graham made changes -
        Attachment PIG-3189.2.patch [ 12569956 ]
        Bill Graham made changes -
        Description {{ivy/pig.pom}} SVN seems to no longer be used. At build time ({{ant set-version}} via {{ant mvn-deploy}}) {{ivy/pig.pom}} is generated from {{ivy/pig-template.xml}}. We should remove {{ivy/pig.pom}} from SVN.

        It would also be good to decouple building the maven artifacts from publishing them, since those two tasks might be done on different hosts.
        {{ivy/pig.pom}} in SVN seems to no longer be used. At build time ({{ant set-version}} via {{ant mvn-deploy}}) {{ivy/pig.pom}} is generated from {{ivy/pig-template.xml}}. We should remove {{ivy/pig.pom}} from SVN.

        It would also be good to decouple building the maven artifacts from publishing them, since those two tasks might be done on different hosts.
        Hide
        Bill Graham added a comment -

        There have been changes to ivy/pig.pom that are not reflected in ivy/pig-template.xml. Particularly antlr is not being included in the published pom because it's not in the template. Will submit a new patch.

        {nofomat}

        $ diff ivy/pig-template.xml ivy/pig.pom
        24c24
        < <version>@version</version>

        > <version>0.9.0-SNAPSHOT</version>
        85,86c85,86
        < </dependency>
        < <dependency>

        > </dependency>
        > <dependency>
        122c122,132
        < <groupId>org.apache.avro</groupId>

        > <groupId>org.antlr</groupId>
        > <artifactId>antlr-runtime</artifactId>
        > <version>3.4</version>
        > </dependency>
        > <dependency>
        > <groupId>org.antlr</groupId>
        > <artifactId>ST4</artifactId>
        > <version>4.0.4</version>
        > </dependency>
        > <dependency>
        > <groupId>org.apache.hadoop</groupId>
        124c134
        < <version>1.5.3</version>

        > <version>1.3.2</version>

        
        
        Show
        Bill Graham added a comment - There have been changes to ivy/pig.pom that are not reflected in ivy/pig-template.xml . Particularly antlr is not being included in the published pom because it's not in the template. Will submit a new patch. {nofomat} $ diff ivy/pig-template.xml ivy/pig.pom 24c24 < <version>@version</version> — > <version>0.9.0-SNAPSHOT</version> 85,86c85,86 < </dependency> < <dependency> — > </dependency> > <dependency> 122c122,132 < <groupId>org.apache.avro</groupId> — > <groupId>org.antlr</groupId> > <artifactId>antlr-runtime</artifactId> > <version>3.4</version> > </dependency> > <dependency> > <groupId>org.antlr</groupId> > <artifactId>ST4</artifactId> > <version>4.0.4</version> > </dependency> > <dependency> > <groupId>org.apache.hadoop</groupId> 124c134 < <version>1.5.3</version> — > <version>1.3.2</version>
        Hide
        Bill Graham added a comment -

        Adding patch #3 which includes antlr in the template.

        Show
        Bill Graham added a comment - Adding patch #3 which includes antlr in the template.
        Bill Graham made changes -
        Attachment PIG-3189.3.patch [ 12570087 ]
        Hide
        Bill Graham added a comment -

        Patch #3 had my *.iws changes in it. Uploading cleaned up patch #4.

        Show
        Bill Graham added a comment - Patch #3 had my *.iws changes in it. Uploading cleaned up patch #4.
        Bill Graham made changes -
        Attachment PIG-3189.4.patch [ 12570421 ]
        Bill Graham made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Daniel Dai made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1m 50s 1 Bill Graham 16/Feb/13 02:08
        Patch Available Patch Available Resolved Resolved
        6d 4h 1m 1 Bill Graham 22/Feb/13 06:10
        Resolved Resolved Closed Closed
        234d 10h 35m 1 Daniel Dai 14/Oct/13 17:46

          People

          • Assignee:
            Bill Graham
            Reporter:
            Bill Graham
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development