Pig
  1. Pig
  2. PIG-3168

TestMultiQueryBasic.testMultiQueryWithSplitInMapAndMultiMerge fails in trunk

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None

      Description

      PIG-2994 made explain with no alias be equivalent to explain on the previous alias. This breaks TestMultiQueryBasic.testMultiQueryWithSplitInMapAndMultiMerge because the previous alias is an auto-generated alias not a user-defined alias.

      The following fixes the test:

               "I = GROUP F2 BY (f7, f8);" +
               "STORE I into 'foo4'  using BinStorage();" +
      -        "explain;";
      +        "explain I;";
      
      1. PIG-3168.patch
        0.6 kB
        Cheolsoo Park
      2. PIG-3168-2.patch
        2 kB
        Cheolsoo Park
      3. PIG-3168-3.patch
        3 kB
        Cheolsoo Park

        Issue Links

          Activity

          Hide
          Cheolsoo Park added a comment -

          Thanks Rohini. Committed to trunk.

          Show
          Cheolsoo Park added a comment - Thanks Rohini. Committed to trunk.
          Hide
          Rohini Palaniswamy added a comment -

          +1

          Show
          Rohini Palaniswamy added a comment - +1
          Hide
          Cheolsoo Park added a comment -

          I noticed that TestShortcuts is broken with my changes to explain in batch mode. I fixed the test in a new patch.

          In fact, I didn't commit PIG-3168-2.patch at all. Since additional changes in the new patch are very minor, I will go ahead commit it.

          Show
          Cheolsoo Park added a comment - I noticed that TestShortcuts is broken with my changes to explain in batch mode. I fixed the test in a new patch. In fact, I didn't commit PIG-3168 -2.patch at all. Since additional changes in the new patch are very minor, I will go ahead commit it.
          Hide
          Rohini Palaniswamy added a comment -

          +1

          Show
          Rohini Palaniswamy added a comment - +1
          Hide
          Cheolsoo Park added a comment -

          TestMultiQueryBasic passes.

          Show
          Cheolsoo Park added a comment - TestMultiQueryBasic passes.
          Hide
          Cheolsoo Park added a comment -

          So here is what it does now:

          • In interactive mode, explain with no alias == explain on the last relation.
          • In batch mode, explain with no alias == explain on the entire script.

          Let me know whether this is not good.

          Show
          Cheolsoo Park added a comment - So here is what it does now: In interactive mode, explain with no alias == explain on the last relation. In batch mode, explain with no alias == explain on the entire script. Let me know whether this is not good.
          Hide
          Cheolsoo Park added a comment -

          Thanks Rohini. I will post a patch that reverts it to the old behavior in batch mode.

          Show
          Cheolsoo Park added a comment - Thanks Rohini. I will post a patch that reverts it to the old behavior in batch mode.
          Hide
          Rohini Palaniswamy added a comment -

          PIG-2994 made explain with no alias be equivalent to explain on the previous alias.

          Shouldn't we revert back the behavior of explain with no alias to older behavior of explaining the whole script instead of fixing the test? It is kind of breaking backward compatibility.

          Show
          Rohini Palaniswamy added a comment - PIG-2994 made explain with no alias be equivalent to explain on the previous alias. Shouldn't we revert back the behavior of explain with no alias to older behavior of explaining the whole script instead of fixing the test? It is kind of breaking backward compatibility.
          Hide
          Cheolsoo Park added a comment -

          Committed to trunk. Thank you Daniel for your review!

          Show
          Cheolsoo Park added a comment - Committed to trunk. Thank you Daniel for your review!
          Hide
          Daniel Dai added a comment -

          +1

          Show
          Daniel Dai added a comment - +1

            People

            • Assignee:
              Cheolsoo Park
              Reporter:
              Cheolsoo Park
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development