[PIG-3160] GFCross uses unnecessary loop

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.12.0
• Component/s: internal-udfs
• Assignee: Sandy Ryza
• Reporter: Sandy Ryza
• Created: 05/Feb/13 19:59
• Updated: 14/Oct/13 16:46
• Resolved: 05/Feb/13 23:26

Description

The GFCross UDF contains the following code:

int[] digits = new int[numInputs];
for (int i=0; i<numInputs; i++){
  if (i == myNumber){
    digits[i] = r.nextInt(numGroupsPerInput);
  }else{
    digits[i] = 0;
 }
}

As int arrays are initialized with all 0s already, this is equivalent to just settings digits[myNumber] and leaving the rest alone.