Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-3087

Refactor TestLogicalPlanBuilder to be meaningful

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.17.0
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      I started doing this as part of another patch, but there are some bigger issues, and I don't have the time to dig in atm.

      That said, a lot of the tests as written don't test anything. I used more modern junit patterns, and discovered we had a lot of tests that weren't functioning properly. Making them function properly unveiled that the general buildLp pattern doesn't work properly anymore for many cases where it would throw an error in grunt, but for whatever reason no error is thrown in the tests.

      Any test with _1 is a test that previous failed, that now doesn't. Some, however, don't make sense so I think what really needs to be done is figure out which should be failing, which shouldn't, and then fix buildLp accordingly.

      I will attach my pass at it, but it is incomplete and needs work.

        Attachments

        1. PIG-3087.1.patch
          62 kB
          Adam Szita
        2. PIG-3087.2.patch
          63 kB
          Adam Szita
        3. PIG-3087.3.patch
          63 kB
          Adam Szita
        4. PIG-3087.4.patch
          63 kB
          Adam Szita
        5. PIG-3087-0.patch
          59 kB
          Jonathan Coveney

          Activity

            People

            • Assignee:
              szita Adam Szita
              Reporter:
              jcoveney Jonathan Coveney
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: