Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is a regression from PIG-2924. The size of output in PigStats used to be off by 1 byte per store, but that was fixed by PIG-2924. However, two test cases in TestPigRunner wasn't corrected, so they fail in trunk.

      The reason why the size of output in PigStats were off by 1 byte per store is because the size variable was initialized by -1 instead of 0.

      long bytes = -1;
      ...
      bytes += status.getLen();
      ...
      
      1. PIG-3066.patch
        2 kB
        Cheolsoo Park

        Issue Links

          Activity

          Cheolsoo Park created issue -
          Cheolsoo Park made changes -
          Field Original Value New Value
          Link This issue is broken by PIG-2924 [ PIG-2924 ]
          Hide
          Cheolsoo Park added a comment -

          Attached is a patch that fixes test cases.

          Show
          Cheolsoo Park added a comment - Attached is a patch that fixes test cases.
          Cheolsoo Park made changes -
          Attachment PIG-3066.patch [ 12554629 ]
          Cheolsoo Park made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Santhosh Srinivasan added a comment -
          Show
          Santhosh Srinivasan added a comment - The review is at https://reviews.apache.org/r/8313/
          Santhosh Srinivasan made changes -
          Hadoop Flags Reviewed [ 10343 ]
          Hide
          Santhosh Srinivasan added a comment -

          +1

          Show
          Santhosh Srinivasan added a comment - +1
          Santhosh Srinivasan made changes -
          Remote Link This issue links to "Review Board (Web Link)" [ 11933 ]
          Hide
          Santhosh Srinivasan added a comment -

          Linking the JIRA to the review board URL

          Show
          Santhosh Srinivasan added a comment - Linking the JIRA to the review board URL
          Hide
          Cheolsoo Park added a comment -

          Thank you for the review, Santhosh.

          I committed it to trunk.

          Show
          Cheolsoo Park added a comment - Thank you for the review, Santhosh. I committed it to trunk.
          Cheolsoo Park made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Daniel Dai made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          1m 54s 1 Cheolsoo Park 22/Nov/12 02:39
          Patch Available Patch Available Resolved Resolved
          35d 2h 3m 1 Cheolsoo Park 27/Dec/12 04:43
          Resolved Resolved Closed Closed
          291d 12h 3m 1 Daniel Dai 14/Oct/13 16:46

            People

            • Assignee:
              Cheolsoo Park
              Reporter:
              Cheolsoo Park
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development