Pig
  1. Pig
  2. PIG-3006

Modernize a chunk of the tests

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:

      • get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
      • Nothing should extend TestCase. Everything should be annotation driven.
      • Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
      • Get rid of MiniCluster use in a handful of cases.

      I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.

      1. PIG-3006-4.patch
        750 kB
        Cheolsoo Park
      2. PIG-3006-3.patch
        712 kB
        Cheolsoo Park
      3. PIG-3006-2.patch
        740 kB
        Jonathan Coveney
      4. PIG-3006-1.patch
        369 kB
        Jonathan Coveney
      5. PIG-3006-0.patch
        369 kB
        Jonathan Coveney

        Issue Links

          Activity

          Jonathan Coveney created issue -
          Jonathan Coveney made changes -
          Field Original Value New Value
          Attachment PIG-3006-0.patch [ 12550821 ]
          Jonathan Coveney made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jonathan Coveney made changes -
          Attachment PIG-3006-1.patch [ 12551011 ]
          Jonathan Coveney made changes -
          Attachment PIG-3006-2.patch [ 12551294 ]
          Jonathan Coveney made changes -
          Link This issue is part of PIG-3016 [ PIG-3016 ]
          Cheolsoo Park made changes -
          Attachment PIG-3006-3.patch [ 12552326 ]
          Cheolsoo Park made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Cheolsoo Park made changes -
          Attachment PIG-3006-4.patch [ 12552421 ]
          Daniel Dai made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Jonathan Coveney
              Reporter:
              Jonathan Coveney
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development