[PIG-3006] Modernize a chunk of the tests

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.12.0
• Patch Info: Patch Available
• Assignee: Jonathan Coveney
• Reporter: Jonathan Coveney
• Created: 25/Oct/12 18:01
• Updated: 14/Oct/13 16:46
• Resolved: 07/Nov/12 06:05

Description

A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:

• get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
• Nothing should extend TestCase. Everything should be annotation driven.
• Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
• Get rid of MiniCluster use in a handful of cases.

I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.

Issue Links

• is part of: PIG-3016 Modernize more tests