Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-3006

Modernize a chunk of the tests

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:

      • get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled in?)
      • Nothing should extend TestCase. Everything should be annotation driven.
      • Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
      • Get rid of MiniCluster use in a handful of cases.

      I've run every test and they pass, EXCEPT TestLargeFile which is failing on trunk anyway.

        Attachments

        1. PIG-3006-0.patch
          369 kB
          Jonathan Coveney
        2. PIG-3006-1.patch
          369 kB
          Jonathan Coveney
        3. PIG-3006-2.patch
          740 kB
          Jonathan Coveney
        4. PIG-3006-3.patch
          712 kB
          Cheolsoo Park
        5. PIG-3006-4.patch
          750 kB
          Cheolsoo Park

          Issue Links

            Activity

              People

              • Assignee:
                jcoveney Jonathan Coveney
                Reporter:
                jcoveney Jonathan Coveney
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: