Pig
  1. Pig
  2. PIG-2995

Refactor unit test temporary file allocation patterns to use FileLocalizer.getTemporaryPath

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.10.0
    • Fix Version/s: None
    • Component/s: build
    • Labels:
      None

      Description

      Pig unit tests have a lot of diverse patterns for temporary file allocation. Not all of them are best practices. There is an abstraction that could house best practices for test temporary file allocation – FileLocalizer.getTemporaryPath. With this, we should be able to have all/most of the temporary file usage fall under just a few methods that can handle arbitrary pig contexts and provide more flexibility around testing pig with different fs implementations.

        Issue Links

          Activity

          Jarek Jarcec Cecho made changes -
          Assignee Jarek Jarcec Cecho [ jarcec ]
          Cheolsoo Park made changes -
          Field Original Value New Value
          Link This issue is related to PIG-2591 [ PIG-2591 ]
          Hide
          Jonathan Coveney added a comment -

          I fully support this effort, and making the tests all follow best practices in general. Some of them are a mess!

          Show
          Jonathan Coveney added a comment - I fully support this effort, and making the tests all follow best practices in general. Some of them are a mess!
          John Gordon created issue -

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              John Gordon
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Development