Pig
  1. Pig
  2. PIG-2933

HBaseStorage is using setScannerCaching which is deprecated

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
    • Patch Info:
      Patch Available

      Description

      HTable.setScannerCaching is deprecated use Scan.setCaching(int)

      Note: I'm on vacation starting tomorrow. If you want I can fix this next week.

      1. PIG-2933.patch
        4 kB
        Prashant Kommireddi
      2. PIG-2933_1.patch
        3 kB
        Prashant Kommireddi

        Activity

        Hide
        Rohini Palaniswamy added a comment -

        Committed to trunk. Thanks Prashant

        Show
        Rohini Palaniswamy added a comment - Committed to trunk. Thanks Prashant
        Hide
        Prashant Kommireddi added a comment -

        Sounds good, thanks.

        Show
        Prashant Kommireddi added a comment - Sounds good, thanks.
        Hide
        Rohini Palaniswamy added a comment -

        I think inner classes ordering on imports is different, it's usually placed below. Let me know if you think otherwise as per Apache pig guidelines.

        Its just a standard ordering and should work with any IDE. Checked that doing a Ctrl+Shift+O in Eclipse puts Map.Entry immediately after Map.

        +1. Will commit this once I get access.

        Show
        Rohini Palaniswamy added a comment - I think inner classes ordering on imports is different, it's usually placed below. Let me know if you think otherwise as per Apache pig guidelines. Its just a standard ordering and should work with any IDE. Checked that doing a Ctrl+Shift+O in Eclipse puts Map.Entry immediately after Map. +1. Will commit this once I get access.
        Hide
        Prashant Kommireddi added a comment -

        1. Makes sense
        2. I think inner classes ordering on imports is different, it's usually placed below. Let me know if you think otherwise as per Apache pig guidelines.

        Show
        Prashant Kommireddi added a comment - 1. Makes sense 2. I think inner classes ordering on imports is different, it's usually placed below. Let me know if you think otherwise as per Apache pig guidelines.
        Hide
        Rohini Palaniswamy added a comment -

        Prashant,
        Thanks for the fix. I just have two minor comments.

        • Can you move the scan.setCaching(caching_); next to scan.setCacheBlocks(false); in initScan()? It will help keeping all the scan settings in a single method.
        • The patch corrects the order of imports. But Map.Entry is moved after Properties. Can you fix that?
        Show
        Rohini Palaniswamy added a comment - Prashant, Thanks for the fix. I just have two minor comments. Can you move the scan.setCaching(caching_); next to scan.setCacheBlocks(false); in initScan()? It will help keeping all the scan settings in a single method. The patch corrects the order of imports. But Map.Entry is moved after Properties. Can you fix that?
        Hide
        Prashant Kommireddi added a comment -

        Smallest patch ever

        Show
        Prashant Kommireddi added a comment - Smallest patch ever

          People

          • Assignee:
            Prashant Kommireddi
            Reporter:
            Ted Malaska
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development