Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11
    • Component/s: None
    • Labels:
      None
    1. PIG-2763.patch
      72 kB
      Mathias Herberts
    2. PIG-2763-7.patch
      83 kB
      Mathias Herberts

      Issue Links

        Activity

        Julien Le Dem created issue -
        Jonathan Coveney made changes -
        Field Original Value New Value
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Hide
        Mathias Herberts added a comment -

        A freakin huge code review...

        This patch adds support for Groovy UDFs.

        Simple UDFs, algebraic UDFs and accumulator UDFs can be defined in Groovy. The definition makes heavy use of annotations.

        Patch does not (yet) cover documentation, but it does have unit tests both for type conversions between Pig and Groovy and Groovy and Pig, and for actual Groovy UDF usage.

        Show
        Mathias Herberts added a comment - A freakin huge code review... This patch adds support for Groovy UDFs. Simple UDFs, algebraic UDFs and accumulator UDFs can be defined in Groovy. The definition makes heavy use of annotations. Patch does not (yet) cover documentation, but it does have unit tests both for type conversions between Pig and Groovy and Groovy and Pig, and for actual Groovy UDF usage.
        Mathias Herberts made changes -
        Attachment PIG-2763.patch [ 12533395 ]
        Hide
        Julien Le Dem added a comment -

        Thank you Mathias!

        Show
        Julien Le Dem added a comment - Thank you Mathias!
        Hide
        Julien Le Dem added a comment -

        Could you create a review at https://reviews.apache.org ?
        Thanks

        Show
        Julien Le Dem added a comment - Could you create a review at https://reviews.apache.org ? Thanks
        Hide
        Mathias Herberts added a comment -

        Done, review 5591 was created. https://reviews.apache.org/r/5591/

        Show
        Mathias Herberts added a comment - Done, review 5591 was created. https://reviews.apache.org/r/5591/
        Hide
        Jonathan Coveney added a comment -

        Mathias,

        You made the review private. Can you please add me?

        Thanks!
        Jon

        Show
        Jonathan Coveney added a comment - Mathias, You made the review private. Can you please add me? Thanks! Jon
        Hide
        Jonathan Coveney added a comment -

        PS Awesome contribution

        Show
        Jonathan Coveney added a comment - PS Awesome contribution
        Hide
        Mathias Herberts added a comment -

        Ooops my mistake, I forgot to publish the review. Corrected.

        Show
        Mathias Herberts added a comment - Ooops my mistake, I forgot to publish the review. Corrected.
        Mathias Herberts made changes -
        Remote Link This issue links to "Code Review #5591 (Web Link)" [ 10300 ]
        Hide
        Mathias Herberts added a comment -

        Added link to Code Review #5591

        Show
        Mathias Herberts added a comment - Added link to Code Review #5591
        Hide
        Mathias Herberts added a comment -

        Latest version of patch, reviewed by Julien Le Dem and Jonathan Coveney in ReviewBoard.

        Show
        Mathias Herberts added a comment - Latest version of patch, reviewed by Julien Le Dem and Jonathan Coveney in ReviewBoard.
        Mathias Herberts made changes -
        Attachment PIG-2763-7.patch [ 12535269 ]
        Julien Le Dem made changes -
        Link This issue is related to PIG-2817 [ PIG-2817 ]
        Hide
        Julien Le Dem added a comment -

        +1
        I'll check the tests pass.
        Mathias if you could update the docs that would be awesome:
        https://issues.apache.org/jira/browse/PIG-2817

        Show
        Julien Le Dem added a comment - +1 I'll check the tests pass. Mathias if you could update the docs that would be awesome: https://issues.apache.org/jira/browse/PIG-2817
        Julien Le Dem made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 0.11 [ 12318878 ]
        Resolution Fixed [ 1 ]
        Hide
        Julien Le Dem added a comment -

        This is merged in TRUNK

        Show
        Julien Le Dem added a comment - This is merged in TRUNK
        Bill Graham made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mathias Herberts
            Reporter:
            Julien Le Dem
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development