Pig
  1. Pig
  2. PIG-2598

Change source structure for sources in other languages

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11
    • Component/s: None
    • Labels:
      None
    • Release Note:
      This was resolved as a part of PIG-2317

      Description

      Currently, the source structure only supports java (ie src/org/apache/etc). The JRuby script support will necessitate a JRuby file as source, and there is currently no home for it. There are a couple options:

      1) the cleanest is moving to src/main/java, src/main/ruby, etc. The issue with this is it would require rebasing all patches. That's pretty big...but as Pig grows, may be necessary (this might be a good chance to fix the formatting and spacing of old files!)
      2) add a src-jruby/ directory
      3) add a src/jruby/ directory

        Issue Links

          Activity

          Hide
          Alan Gates added a comment -

          As said on the dev list, I vote for options 2 or 3 until there is a clear benefit to option 1. I don't know of any benefit to 1 beyond maven conformance. Conforming to maven isn't important until we use maven.

          Show
          Alan Gates added a comment - As said on the dev list, I vote for options 2 or 3 until there is a clear benefit to option 1. I don't know of any benefit to 1 beyond maven conformance. Conforming to maven isn't important until we use maven.
          Hide
          Daniel Dai added a comment -

          Either 2 or 3 is fine. I like 3 slightly better cuz I saw this layout in other projects, such as jruby itself.

          Show
          Daniel Dai added a comment - Either 2 or 3 is fine. I like 3 slightly better cuz I saw this layout in other projects, such as jruby itself.
          Hide
          Jonathan Coveney added a comment -

          Alan suggested going with the maven form for ruby off the bat, and leaving the rest at bay, so I'm going to put my script in src/main/jruby and go from there. Sound ok?

          Show
          Jonathan Coveney added a comment - Alan suggested going with the maven form for ruby off the bat, and leaving the rest at bay, so I'm going to put my script in src/main/jruby and go from there. Sound ok?
          Hide
          Daniel Dai added a comment -

          Sounds Ok.

          Show
          Daniel Dai added a comment - Sounds Ok.

            People

            • Assignee:
              Unassigned
              Reporter:
              Jonathan Coveney
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development