[PIG-2582] Store size in bytes (not mbytes) in ResourceStatistics

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.12.0
• Patch Info: Patch Available
• Release Note: Committed, thanks Prashant!
• Assignee: Prashant Kommireddi
• Reporter: Travis Crawford
• Created: 13/Mar/12 20:21
• Updated: 14/Oct/13 16:46
• Resolved: 08/Nov/12 06:23

Description

In ResourceStatistics.java we see mBytes is public, and has a public getter/setter.

47	    public Long mBytes; // size in megabytes

196	    public Long getmBytes() {
197	        return mBytes;
198	    }
199	    public ResourceStatistics setmBytes(Long mBytes) {
200	        this.mBytes = mBytes;
201	        return this;
202	    }

Typically sizes are stored as bytes, potentially having convenience functions to return with different units.

If mBytes can be marked private without causing woes it might be worth storing size as bytes instead.