Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Component/s: None
    • Labels:
      None

      Description

      Creating a way to add UDFs to pig

      1. PIG-246_v1.patch
        10 kB
        Olga Natkovich
      2. PIG-246_v2.patch
        11 kB
        Olga Natkovich

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        20d 3h 17m 1 Olga Natkovich 12/Jun/08 00:45
        Resolved Resolved Closed Closed
        650d 22h 15m 1 Alan Gates 24/Mar/10 22:01
        Alan Gates made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Olga Natkovich made changes -
        Fix Version/s 0.1.0 [ 12312848 ]
        Olga Natkovich made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Olga Natkovich added a comment -

        the repository has been added. documentation is next.

        Show
        Olga Natkovich added a comment - the repository has been added. documentation is next.
        Hide
        Olga Natkovich added a comment -

        I went back and forth on that and used UDF on top so that users know what's there and then piggybank in the actuall org.apache.pig hierarchy. But I am ok to change that if others think it is best to call top level dir piggybank.

        Show
        Olga Natkovich added a comment - I went back and forth on that and used UDF on top so that users know what's there and then piggybank in the actuall org.apache.pig hierarchy. But I am ok to change that if others think it is best to call top level dir piggybank.
        Hide
        Patrick Hunt added a comment -

        Shouldn't the dir structure be contrib/piggybank/... rather than contrib/udfs/... ?

        Show
        Patrick Hunt added a comment - Shouldn't the dir structure be contrib/piggybank/... rather than contrib/udfs/... ?
        Olga Natkovich made changes -
        Attachment PIG-246_v2.patch [ 12383519 ]
        Hide
        Olga Natkovich added a comment -

        Updated patch

        Show
        Olga Natkovich added a comment - Updated patch
        Hide
        Olga Natkovich added a comment -

        Here is new structure. Please, review:

        A contrib
        A contrib/udfs
        A contrib/udfs/java
        A contrib/udfs/java/src
        A contrib/udfs/java/src/main
        A contrib/udfs/java/src/main/java
        A contrib/udfs/java/src/main/java/org
        A contrib/udfs/java/src/main/java/org/apache
        A contrib/udfs/java/src/main/java/org/apache/pig
        A contrib/udfs/java/src/main/java/org/apache/pig/piggybank
        A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation
        A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation/string
        A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation/string/UPPER.java
        A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation/math
        A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation/util
        A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation/stats
        A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/comparison
        A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/filtering
        A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/storage
        A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/grouping
        A contrib/udfs/java/src/test
        A contrib/udfs/java/src/test/java
        A contrib/udfs/java/src/test/java/org
        A contrib/udfs/java/src/test/java/org/apache
        A contrib/udfs/java/src/test/java/org/apache/pig
        A contrib/udfs/java/src/test/java/org/apache/pig/piggybank
        A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test
        A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/evaluation
        A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/evaluation/TestEvalString.java
        A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/filtering
        A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/comparison
        A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/grouping
        A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/storage
        A contrib/udfs/java/lib
        A contrib/udfs/java/build.xml

        Show
        Olga Natkovich added a comment - Here is new structure. Please, review: A contrib A contrib/udfs A contrib/udfs/java A contrib/udfs/java/src A contrib/udfs/java/src/main A contrib/udfs/java/src/main/java A contrib/udfs/java/src/main/java/org A contrib/udfs/java/src/main/java/org/apache A contrib/udfs/java/src/main/java/org/apache/pig A contrib/udfs/java/src/main/java/org/apache/pig/piggybank A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation/string A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation/string/UPPER.java A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation/math A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation/util A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/evaluation/stats A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/comparison A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/filtering A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/storage A contrib/udfs/java/src/main/java/org/apache/pig/piggybank/grouping A contrib/udfs/java/src/test A contrib/udfs/java/src/test/java A contrib/udfs/java/src/test/java/org A contrib/udfs/java/src/test/java/org/apache A contrib/udfs/java/src/test/java/org/apache/pig A contrib/udfs/java/src/test/java/org/apache/pig/piggybank A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/evaluation A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/evaluation/TestEvalString.java A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/filtering A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/comparison A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/grouping A contrib/udfs/java/src/test/java/org/apache/pig/piggybank/test/storage A contrib/udfs/java/lib A contrib/udfs/java/build.xml
        Hide
        Olga Natkovich added a comment -

        Pi,

        We don't have plans to move to maven. I think the idea is to have structure that would work for maven if we decide to move their later or if some of the users want to use it.

        Since the changes are pretty minor and don't take anything away from using ant, I saw no reason not to follow the structure.

        What do you think?

        Show
        Olga Natkovich added a comment - Pi, We don't have plans to move to maven. I think the idea is to have structure that would work for maven if we decide to move their later or if some of the users want to use it. Since the changes are pretty minor and don't take anything away from using ant, I saw no reason not to follow the structure. What do you think?
        Hide
        Pi Song added a comment -

        pom.xml is a maven build file. Kishore, are you proposing to move from ant to maven? I don't see its advantage at this stage because we don't have many inter-dependent components right now. (That doesn't mean it's not gonna be useful later)

        Show
        Pi Song added a comment - pom.xml is a maven build file. Kishore, are you proposing to move from ant to maven? I don't see its advantage at this stage because we don't have many inter-dependent components right now. (That doesn't mean it's not gonna be useful later)
        Hide
        Patrick Hunt added a comment -

        Just to verify - UPPER.java contains class "evaluation.string.UPPER", correct?

        Any reason to use TestX.java rather than XTest.java? Is that something maven prefers one way or the other?

        What will the name of the generated jar file be? udfs.jar? pigudfs.jar? other...?

        How about adding another jira "add pig udf to CI/Hudson" that depends on this item? Ditto for updating the Pig docs/wiki providing details on this contrib package.

        Show
        Patrick Hunt added a comment - Just to verify - UPPER.java contains class "evaluation.string.UPPER", correct? Any reason to use TestX.java rather than XTest.java? Is that something maven prefers one way or the other? What will the name of the generated jar file be? udfs.jar? pigudfs.jar? other...? How about adding another jira "add pig udf to CI/Hudson" that depends on this item? Ditto for updating the Pig docs/wiki providing details on this contrib package.
        Hide
        Olga Natkovich added a comment -

        I am fine with this structure.

        what is the content of pom.xml?

        Show
        Olga Natkovich added a comment - I am fine with this structure. what is the content of pom.xml?
        Hide
        kishore gopalakrishna added a comment -

        It will be nice if the structure follows maven directory structure. The difference is between the aboves structure and maven structure is very minor and can be accomplished easily

        A contrib
        A contrib/udfs
        A contrib/udfs/java
        A contrib/udfs/java/src/main/java
        A contrib/udfs/java/src/main/java/evaluation
        A contrib/udfs/java/src/main/java/evaluation/string
        A contrib/udfs/java/src/main/java/evaluation/string/UPPER.java
        A contrib/udfs/java/src/main/java/evaluation/math
        A contrib/udfs/java/src/main/java/evaluation/util
        A contrib/udfs/java/src/main/java/evaluation/stats
        A contrib/udfs/java/src/main/java/comparison
        A contrib/udfs/java/src/main/java/filtering
        A contrib/udfs/java/src/main/java/storage
        A contrib/udfs/java/src/main/java/grouping
        A contrib/udfs/java/src/test/java
        A contrib/udfs/java/src/test/java/evaluation
        A contrib/udfs/java/src/test/java/evaluation/TestEvalString.java
        A contrib/udfs/java/src/test/java/filtering
        A contrib/udfs/java/src/test/java/storage
        A contrib/udfs/java/src/test/java/grouping
        A contrib/udfs/java/src/test/java/comparison
        A contrib/udfs/java/lib
        A contrib/udfs/java/build.xml
        A contrib/udfs/java/pom.xml

        pom.xml is for maven
        Please feel free to comment

        Show
        kishore gopalakrishna added a comment - It will be nice if the structure follows maven directory structure. The difference is between the aboves structure and maven structure is very minor and can be accomplished easily A contrib A contrib/udfs A contrib/udfs/java A contrib/udfs/java/src/main/java A contrib/udfs/java/src/main/java/evaluation A contrib/udfs/java/src/main/java/evaluation/string A contrib/udfs/java/src/main/java/evaluation/string/UPPER.java A contrib/udfs/java/src/main/java/evaluation/math A contrib/udfs/java/src/main/java/evaluation/util A contrib/udfs/java/src/main/java/evaluation/stats A contrib/udfs/java/src/main/java/comparison A contrib/udfs/java/src/main/java/filtering A contrib/udfs/java/src/main/java/storage A contrib/udfs/java/src/main/java/grouping A contrib/udfs/java/src/test/java A contrib/udfs/java/src/test/java/evaluation A contrib/udfs/java/src/test/java/evaluation/TestEvalString.java A contrib/udfs/java/src/test/java/filtering A contrib/udfs/java/src/test/java/storage A contrib/udfs/java/src/test/java/grouping A contrib/udfs/java/src/test/java/comparison A contrib/udfs/java/lib A contrib/udfs/java/build.xml A contrib/udfs/java/pom.xml pom.xml is for maven Please feel free to comment
        Hide
        Pi Song added a comment -

        Just to say "no objection"

        Show
        Pi Song added a comment - Just to say "no objection"
        Olga Natkovich made changes -
        Field Original Value New Value
        Attachment PIG-246_v1.patch [ 12382605 ]
        Hide
        Olga Natkovich added a comment -

        Here is the proposed structure for the repository. Please, critique:

        A contrib
        A contrib/udfs
        A contrib/udfs/java
        A contrib/udfs/java/src
        A contrib/udfs/java/src/evaluation
        A contrib/udfs/java/src/evaluation/string
        A contrib/udfs/java/src/evaluation/string/UPPER.java
        A contrib/udfs/java/src/evaluation/math
        A contrib/udfs/java/src/evaluation/util
        A contrib/udfs/java/src/evaluation/stats
        A contrib/udfs/java/src/comparison
        A contrib/udfs/java/src/filtering
        A contrib/udfs/java/src/storage
        A contrib/udfs/java/src/grouping
        A contrib/udfs/java/test
        A contrib/udfs/java/test/evaluation
        A contrib/udfs/java/test/evaluation/TestEvalString.java
        A contrib/udfs/java/test/filtering
        A contrib/udfs/java/test/storage
        A contrib/udfs/java/test/grouping
        A contrib/udfs/java/test/comparison
        A contrib/udfs/java/lib
        A contrib/udfs/java/build.xml

        Show
        Olga Natkovich added a comment - Here is the proposed structure for the repository. Please, critique: A contrib A contrib/udfs A contrib/udfs/java A contrib/udfs/java/src A contrib/udfs/java/src/evaluation A contrib/udfs/java/src/evaluation/string A contrib/udfs/java/src/evaluation/string/UPPER.java A contrib/udfs/java/src/evaluation/math A contrib/udfs/java/src/evaluation/util A contrib/udfs/java/src/evaluation/stats A contrib/udfs/java/src/comparison A contrib/udfs/java/src/filtering A contrib/udfs/java/src/storage A contrib/udfs/java/src/grouping A contrib/udfs/java/test A contrib/udfs/java/test/evaluation A contrib/udfs/java/test/evaluation/TestEvalString.java A contrib/udfs/java/test/filtering A contrib/udfs/java/test/storage A contrib/udfs/java/test/grouping A contrib/udfs/java/test/comparison A contrib/udfs/java/lib A contrib/udfs/java/build.xml
        Olga Natkovich created issue -

          People

          • Assignee:
            Olga Natkovich
            Reporter:
            Olga Natkovich
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development